Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow passing url to download tarball and install packages #404

Open
rymarinelli opened this issue Jun 6, 2022 · 2 comments
Open

Comments

@rymarinelli
Copy link

rymarinelli commented Jun 6, 2022

As a user, I want to be able to specify the url under the repo in the YAML and download a package from source.

Repos:
  - marginaleffects: https://cloud.r-project.org/src/contrib/marginaleffects_0.5.0.tar.gz
  
Customizations:
  Packages:
  - marginaleffects: {Type: source}
@dpastoor
Copy link
Contributor

dpastoor commented Jun 6, 2022

One thing you might consider, is this functionality is already largely present in the Tarballs implementation, it just knows how to find stuff on the filesystem. It wouldn't be that significant of a code change to instead also allow that to be a URL.

For example, https://github.com/metrumresearchgroup/pkgr/blob/develop/cmd/tarballOps.go#L56 just expects a path on the filesystem, could instead detect if strings.Prefix("http") .... then its a remote tarball, go download it first then begin.

Then the implementation would be:

Tarballs:
- https://cloud.r-project.org/src/contrib/marginaleffects_0.5.0.tar.gz

@kyleam
Copy link
Collaborator

kyleam commented Jun 6, 2022

@dpastoor I think that's a good point (and had the similar thought when reading the initial post). And conceptually the Tarballs section feels more appropriate to me than Repos because a URL pointing to a package tarball isn't a repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants