You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you call VimeoClient.UpdateVideoMetadataAsync you don't have a positive indicator that the operation succeeded. You know the call was made, but you don't know that the update happened. This is especially important if what you are updating isn't a property returned with a GetVideoAsync call (such as "password" to get the string of the currently set access password on the video -- if you update the password right now, I haven't found a way within this library to verify that it changed as expected.).
I'd like to suggest that the various Update/Edit methods be modified to return a boolean value that represents the result of the underlying web api call. This should be non-breaking on existing implementations (calling a function as a method will simply discard the result), but should also provide benefit for future implementation (the coder can check if the request succeeded).
The text was updated successfully, but these errors were encountered:
It's late (for me) and I apologize for missing that a non-success will THROW for you. I guess wrapping the update calls in a try-catch (with the catch handling the same as the "if it didn't succeed" logic) could work.
At the very least I think you're down to preference and how you were trained at this point.
If you call VimeoClient.UpdateVideoMetadataAsync you don't have a positive indicator that the operation succeeded. You know the call was made, but you don't know that the update happened. This is especially important if what you are updating isn't a property returned with a GetVideoAsync call (such as "password" to get the string of the currently set access password on the video -- if you update the password right now, I haven't found a way within this library to verify that it changed as expected.).
I'd like to suggest that the various Update/Edit methods be modified to return a boolean value that represents the result of the underlying web api call. This should be non-breaking on existing implementations (calling a function as a method will simply discard the result), but should also provide benefit for future implementation (the coder can check if the request succeeded).
The text was updated successfully, but these errors were encountered: