Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression on detection of python bin #126

Closed
mr-majkel opened this issue Jan 26, 2024 · 1 comment
Closed

regression on detection of python bin #126

mr-majkel opened this issue Jan 26, 2024 · 1 comment

Comments

@mr-majkel
Copy link

With the changes done in #121, .env is used as one of the potential candidates for the directory containing python binary, however it is quite common used as file for storing environment variables that can be automatically sourced by different frameworks and tools. These include docker-compose, as well as python packages like python-dotenv, or django.

I would like to suggest a change that would check if the file found is a directory before actually trying to use it for python binary lookup.

mfussenegger added a commit that referenced this issue Feb 1, 2024
Should solve #126

Maybe this is good enough - another option would be to double check the
if the python path exists, but that would add some extra workload.
mfussenegger added a commit that referenced this issue Feb 1, 2024
Should solve #126

Maybe this is good enough - another option would be to double check the
if the python path exists, but that would add some extra workload.
@mfussenegger
Copy link
Owner

Thanks for pointing out. I added an additional directory check: #128

If that still causes problem let me know - I'd have to add another check on the full python path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants