Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote Feature fails on Sublime Text 3 #78

Open
shaaati opened this issue Feb 17, 2015 · 1 comment
Open

Footnote Feature fails on Sublime Text 3 #78

shaaati opened this issue Feb 17, 2015 · 1 comment

Comments

@shaaati
Copy link

shaaati commented Feb 17, 2015

On Sublime Text 3, the footnote shortcut fails and prints the following to the console:

Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 549, in run_
    return self.run(edit)
  File "footnotes in /Users/phil/Library/Application Support/Sublime Text 3/Installed Packages/Restructured Text (RST) Snippets.sublime-package", line 109, in run
TypeError: begin_edit() missing 2 required positional arguments: 'edit_token' and 'cmd'

As far as I found out, Sublime Text 3 has changed the way begin_edit() is used.

jimklo added a commit to jimklo/sublime-rst-completion that referenced this issue Mar 24, 2015
1. ST3 disallows access to view.begin_edit() and view.end_edit() since it's passed into the TextCommand.
2. Python3 doesn't allow you to sort dict_keys, so need to cast to list(dict_keys).sort().
@jimklo
Copy link
Contributor

jimklo commented Mar 24, 2015

Found this out too, and just updated to ST3. Here's a PR to fix. Enjoy!

mgaitan added a commit that referenced this issue Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants