Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional configuration options #1

Open
haze opened this issue Jul 9, 2023 · 1 comment
Open

Additional configuration options #1

haze opened this issue Jul 9, 2023 · 1 comment

Comments

@haze
Copy link

haze commented Jul 9, 2023

I’m interested in using this tool to generate my confirmation (even if just as a starting point).

Im wondering about next steps (I’m interested in contributing, but am not well versed on Elisp/Emacs best practices & conventions) for the following features:

  • tree-sitter based language configurations
  • kind-icons for corfu
  • org exporters like ox-gfm
  • Emacs daemon font work (i have some weird hack to get the font to stick to new frames from the daemon)
@mgmarlow
Copy link
Owner

Hello! I appreciate the interest, there's definitely room for some more options in the form.

In general, when picking new features I'd consider the following:

  • Is it easy to explain in a one line bullet point?
  • Is it relatively self-contained and doesn't have many dependencies on other packages/configuration settings?
  • Does it seem like something that is generally useful (e.g. a lot of people understand and desire the feature)?

I personally like your tree-sitter and kind-icons ideas the best. Tree sitter is very desirable and fits the Emacs 29 theme really well. Kind-icons is neat and I think could go into a general "font upgrades" option (maybe bundled w/ the daemon font work you mentioned?).

I'm not sure where I'd fit the org exporters, but maybe we could add a note-taking section w/ some org-mode upgrades, since org-mode is one of the killer features of Emacs.

These sound like new features, so I'd build a PR with these things:

  1. Add the option to templates/index.html w/ the feature value/description
  2. Add the emacs lisp code and documentation string to src/features.rs (I write the package code in a .el buffer & use fill-paragraph to align the documentation comments, then paste it into the Rust code)

I don't currently have CD currently set up so after the PR is merged I'll deploy it to prod.

Happy to help out if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants