Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Remote Code Execution Vulnerability #52

Open
tch1bo opened this issue Nov 17, 2018 · 0 comments
Open

Possible Remote Code Execution Vulnerability #52

tch1bo opened this issue Nov 17, 2018 · 0 comments

Comments

@tch1bo
Copy link

tch1bo commented Nov 17, 2018

Hey,

I noticed that code in line 162 of browser/views.py (

retcode = os.system(cmd)
) is vulnerable to Remote Code Execution (https://en.wikipedia.org/wiki/Arbitrary_code_execution). The user input flows from the filename field of the HTML form into the os.system() call. An attacker can provide input like "; some_other_command #" to execute arbitrary commands on your server.

I would suggest fixing this issue by e.g. replace os.system() with the subprocess.call() function from Python standard library.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant