Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies in .sa output #3

Open
4 tasks
ltalirz opened this issue Jul 12, 2018 · 0 comments
Open
4 tasks

inconsistencies in .sa output #3

ltalirz opened this issue Jul 12, 2018 · 0 comments

Comments

@ltalirz
Copy link
Collaborator

ltalirz commented Jul 12, 2018

Since I've anyhow written the parsers for the moment, I noticed some inconsistencies in the .sa format.

First an example output:

 @ HKUST-1.sa Unitcell_volume: 18280.8   Density: 0.879097   ASA_A^2:
        3545.59 ASA_m^2/cm^3: 1939.51 ASA_m^2/g: 2206.26 NASA_A^2: 0
        NASA_m^2/cm^3: 0 NASA_m^2/g: 0 Number_of_channels: 1
        Channel_surface_area_A^2: 3545.59 Number_of_pockets: 0
        Pocket_surface_area_A^2:
  • Pocket_surface_area_A^2:
    is not followed by any number. This makes the format unnecessarily harder to parse.
    Better simply write 0.
  • "Density": 0.748207 is lacking units
  • "Unitcell_volume": 6415.16 is lacking units
  • (minor) Strictly speaking, ASA_m^2/cm^3 and ASA_m^2/g should be renamed to ASA/V_m^2/cm^3, ASA/M_m^2/g , since they are not the same quantity as ASA (same for NASA)
@ltalirz ltalirz changed the title inconsistency in .sa output inconsistencies in .sa output Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant