Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data down, actions up #120

Open
jelhan opened this issue Jan 22, 2018 · 6 comments
Open

data down, actions up #120

jelhan opened this issue Jan 22, 2018 · 6 comments

Comments

@jelhan
Copy link

jelhan commented Jan 22, 2018

ember-drag-drop does not follow data down, actions up (DDAU) pattern yet. It was discussed and future support announced in some issues (#115, #57, #39). How is the status about that one and is there anything blocking that change?

@dgavey
Copy link
Collaborator

dgavey commented Jan 22, 2018

Well, it's a pretty major change that would break every existing use currently, so not so simple to just change it.

My loose plan was to do a major refactor at some point to follow DDAU and other changes, but it would be a major version change and obviously not backward compatible.

@boris-petrov
Copy link
Contributor

@dgavey - this is already implemented so this issue can be closed.

@jelhan
Copy link
Author

jelhan commented Aug 31, 2018

Current master does not implement DDAU - at least not for all components. E.g. {{sortable-objects}} still modifies property passed in as sortableObjectList as it's shown by this test.

#123 was such a big change that I'm not sure if this case was just missed or if it does not address DDAU at all. In the discussion of that PR closure actions and DDAU was mixed up a lot. I've had a look at the changes in tests and that ones was only about closure actions but not about DDAU.

The main point about data down, actions up principle is not to modify any data passed into a component.

@boris-petrov
Copy link
Contributor

@jelhan - you're right. So this issue remains.

@carlosgalveias
Copy link

Any plans to fix this soon? :)

I am using a component that its source is a computed.sort property and really could use this.

Thanks

@dgavey
Copy link
Collaborator

dgavey commented Apr 30, 2019

PR's welcome. I'm happy to maintain this project (from a managerial perspective), but I really don't have a lot of extra time to spend on it currently unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants