New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable() can not work #11

Open

Namide opened this issue Oct 30, 2019 · 0 comments · May be fixed by #23

Namide commented Oct 30, 2019

This listeners can not be removed.

this.target.addEventListener('touchstart', this.recordTouchStartValues.bind(this));
this.target.addEventListener('touchend', this.detectSwipeDirection.bind(this));

Because this.recordTouchStartValues.bind(this) !== this.recordTouchStartValues.bind(this) (the pointer is new every time bind is called).

So the function disable() will not remove the listeners.

Please store this.xxx.bind(this) in variables and add and remove listeners with the same variables.

The text was updated successfully, but these errors were encountered:

rquanx linked a pull request

that will close this issue

fix: store events for support disable #23

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment