Skip to content

Commit

Permalink
drm/xe: Drop VM dma-resv lock on xe_sync_in_fence_get failure in exec…
Browse files Browse the repository at this point in the history
… IOCTL

Upon failure all locks need to be dropped before returning to the user.

Fixes: 58480c1 ("drm/xe: Skip VMAs pin when requesting signal to the last XE_EXEC")
Cc: <[email protected]>
Signed-off-by: Matthew Brost <[email protected]>
Reviewed-by: Tejas Upadhyay <[email protected]>
Reviewed-by: Rodrigo Vivi <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
(cherry picked from commit 7d1a425)
Signed-off-by: Lucas De Marchi <[email protected]>
  • Loading branch information
mbrost05 authored and lucasdemarchi committed Nov 5, 2024
1 parent af797b8 commit 64a2b6e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/xe/xe_exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ int xe_exec_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
fence = xe_sync_in_fence_get(syncs, num_syncs, q, vm);
if (IS_ERR(fence)) {
err = PTR_ERR(fence);
xe_vm_unlock(vm);
goto err_unlock_list;
}
for (i = 0; i < num_syncs; i++)
Expand Down

0 comments on commit 64a2b6e

Please sign in to comment.