Skip to content

Commit

Permalink
vDPA/ifcvf: Fix pci_read_config_byte() return code handling
Browse files Browse the repository at this point in the history
ifcvf_init_hw() uses pci_read_config_byte() that returns
PCIBIOS_* codes. The error handling, however, assumes the codes are
normal errnos because it checks for < 0.
Convert the error check to plain non-zero check.

Fixes: 5a2414b ("virtio: Intel IFC VF driver for VDPA")
Signed-off-by: Yuan Can <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Acked-by: Jason Wang <[email protected]>
Acked-by: Zhu Lingshan <[email protected]>
  • Loading branch information
Yuan Can authored and mstsirkin committed Nov 6, 2024
1 parent 03a942f commit 7f8825b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/vdpa/ifcvf/ifcvf_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *pdev)
u32 i;

ret = pci_read_config_byte(pdev, PCI_CAPABILITY_LIST, &pos);
if (ret < 0) {
if (ret) {
IFCVF_ERR(pdev, "Failed to read PCI capability list\n");
return -EIO;
}
Expand Down

0 comments on commit 7f8825b

Please sign in to comment.