Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables MySQL in Dockerfile #54

Open
nielsdrost7 opened this issue Feb 12, 2025 · 1 comment
Open

Environment variables MySQL in Dockerfile #54

nielsdrost7 opened this issue Feb 12, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nielsdrost7
Copy link

nielsdrost7 commented Feb 12, 2025

Hey,
I figured you were preparing 1.6.2, so I thought I'd help a bit.

I haven't reproduced the bug, I just read the Dockerfile

Describe the bug
In Dockerfile the mysql host is mysql, but in docker-compose.yml it is mariadb_10_4

When I look at the Dockerfile, I see this:

ENV IP_SOURCE="https://github.com/InvoicePlane/InvoicePlane/releases/download" \
    IP_VERSION="v1.6.2" \
    MYSQL_HOST="mysql" \ ....

But in the docker-compose.yml file you perfectly start mariadb with service name mariadb_10_4 (something like that).
That doesn't match

To Reproduce
Steps to reproduce the behavior:

  1. docker-compose up -d
  2. It should bring up mariadb as a service
  3. MYSQL_HOST is used as a variable in ipconfig.php, so if it says mysql there, then that ENV` variable is wrong.

Expected behavior
While running /setup I would expect the mysql host to be mariadb_10_4

Additional context
In Docker questions for InvoicePlane the most related question in general is about the name of the database host.

@nielsdrost7 nielsdrost7 added the bug Something isn't working label Feb 12, 2025
@mhzawadi
Copy link
Owner

Morning 👋🏼

I have made the Dockerfile match the compose file, that should now work. Thanks for flagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants