Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logfile deletion causes S3 uploads to crash #25

Open
excalq opened this issue Mar 24, 2015 · 0 comments
Open

Logfile deletion causes S3 uploads to crash #25

excalq opened this issue Mar 24, 2015 · 0 comments

Comments

@excalq
Copy link

excalq commented Mar 24, 2015

Hi, I love this script, and I'm using aws s3 --sync to upload $BACKUPDIR to s3, via the $POSTBACKUP hook. However, since the end of the script calls

rm -f "$LOGFILE" "$LOGERR"

The upload operation will fail partially through. This was surprisingly hard to debug (I thought files were missing due to cleanup or rotation). Anyway, having an option to disable the logfile purge, or wait until $POSTBACKUP finishes could be useful. (Which might be trick with aws s3's async behavior.)

In anycase, there might be someone else who finds this issue useful in the course of debugging. 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant