Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login failure when password contains dollar sign $ #79

Open
dkathmann opened this issue Feb 4, 2023 · 9 comments
Open

Login failure when password contains dollar sign $ #79

dkathmann opened this issue Feb 4, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@dkathmann
Copy link

I just had the issue that I couldn't login with the plugin using my account but the account of my partner worked. We could narrow it down to the password length. My password that didn't work initially was quite long and a shorter one worked instantly.

@michaelherger
Copy link
Owner

How long was "quite long"? Could it be the password input field isn't long enough?

@dkathmann
Copy link
Author

The password was 43 characters long. The input field doesn't seem to cut it. Also the http request seems to include the whole password.

@michaelherger
Copy link
Owner

Well, the maximum size of that input field is set to 40... it's a LMS default for these kinds of input fields.

@dkathmann
Copy link
Author

As far as I know the size attribute just determines the width of the input field and doesn't restrict the password itself.

@michaelherger
Copy link
Owner

You're right, of course. Still odd.

What http request are you referring to? The auth call wouldn't use http, but some Spotify specific interaction. Could it have been a special character in your password?

@dkathmann
Copy link
Author

Sorry, I meant the POST request to http://<MY_SERVER>:9000/plugins/Spotty/settings/authentication.html?playerid=<MY_PLAYER_ID>; the request payloads includes the password in plain text (I've only checked this superficially).

The only special characters in the password were $ and ! . The new one that worked doesn't have the $ in it anymore.

@michaelherger
Copy link
Owner

Could you check with another dollar sign in the shorter PW? Would that be the issue? What platform are you running LMS on? I have a vague memory of having dealt with a $ sign related issue before.

@dkathmann
Copy link
Author

I just added one $ to the short password, removed the account from Spotty and tried to add it again which doesn't work. I also tried adding it with a longer password again (without the $) which works.

I'm running LMS in a Docker container on a Raspberry Pi 4 with Raspberry Pi OS.

@dkathmann dkathmann changed the title Login failure with longer passwords Login failure when password contains dollar sign $ Feb 6, 2023
@michaelherger
Copy link
Owner

Thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants