Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_column and generator behavior for missing type #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Oct 21, 2023

  1. Run doctest helper initializer after connection

    Without this, ActiveRecord does not yet know which type of adapter to
    use. This makes monkey patching the specific adapter class(es) that you
    need impossible.
    
    This mirrors what we do in the spec helper.
    michaelherold committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    fcad5d1 View commit details
    Browse the repository at this point in the history
  2. Fix links in the changelogs

    These were typos in the URLs for comparison links between versions. They
    should now all work correctly.
    michaelherold committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    568f28d View commit details
    Browse the repository at this point in the history
  3. Fix add_column behavior for missing type

    When using `add_column`, the definition methods for `ksuid` and
    `ksuid_binary` are not used like when using `table.ksuid` since
    `add_column` creates the column directly.
    
    This change makes it so any column definition can handle both `ksuid`
    and `ksuid_binary` correctly by monkey-patching the method that creates
    the column definitions.
    michaelherold committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    14e859c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Fix generator behavior for ksuid column types

    This change makes it so `rails generate model example:ksuid` works as
    expected. I am unsure how fragile this test is. Ideally, we would have a
    test that runs the generator against a dummy app and asserts on the
    outcome, but I don't have the spoons to manage that right now.
    michaelherold committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7d8d52c View commit details
    Browse the repository at this point in the history