Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme issue #13

Open
ThraaxSession opened this issue Oct 18, 2016 · 9 comments
Open

Dark theme issue #13

ThraaxSession opened this issue Oct 18, 2016 · 9 comments
Assignees
Milestone

Comments

@ThraaxSession
Copy link

ThraaxSession commented Oct 18, 2016

Hi,

nice app :)
here is a little issue with highlighting running under gnome3:

bildschirmfoto von 2016-10-18 19-55-37

@canweriotnow
Copy link

Running under xubuntu (xfce4) the Dark theme seems to just invert the text color without changing anything else:

screenshot_2016-10-19_13-47-26

@michaldaniel
Copy link
Owner

michaldaniel commented Oct 21, 2016

@GinoHereIam I'm pretty sure I know what causes that, but could you send the ebook file to my mail: [email protected] so I can quickly confirm fix myself?

@canweriotnow This is another issue all together, it would be best to make separate thread and I'll need your system info: GTK version, and more info on xubuntu and xface version. I might not be able to fix it tho. I'm simply asking system to change app theme to GTK dark theme and change fonts CSS in transparent webkit, I see you are even missing some icons.

Does the issue persist after restarting the app? Could you install gtk-3-examples and run gtk3-wiget-factory and see if you change in the settings there to "Dark theme" the app changes and looks fine?

@michaldaniel
Copy link
Owner

michaldaniel commented Oct 21, 2016

@GinoHereIam On another note, did you mess with icons or something in the source or in any other way? None of them seems correct but they look gnome default. This seems really strange, I mean I am testing this app under Ubuntu Gnome and elementaryOS Pantheon.

@michaldaniel michaldaniel added this to the 1.0 milestone Oct 21, 2016
@michaldaniel michaldaniel self-assigned this Oct 21, 2016
michaldaniel pushed a commit that referenced this issue Oct 22, 2016
@michaldaniel
Copy link
Owner

@GinoHereIam This shouldn't be an issue any more but I'll be doing big base.css work to do some styling of common epub selectors soon in order to fix similar possible formatting bugs.

@ThraaxSession
Copy link
Author

ThraaxSession commented Oct 22, 2016

Hi @michaldaniel, here is the link to the epub: http://downloads.mysql.com/docs/connector-cpp-en.epub. :)
Oh yes I used different icons and themes, right now I am suing Numix icons/themes Fedora 25, but it works pretty fine now!

@michaldaniel
Copy link
Owner

@GinoHereIam Your issue should be solved. I had to take break from development. I'm going to keep it open and investigate @canweriotnow reported problem.

@AnwarShah
Copy link

Same issue happens in MATE environment with Mint-X theme. The text's aren't readable at all in Light model

@dweymouth
Copy link

dweymouth commented Jul 27, 2017

Can confirm the same issue seen by @AnwarShah is still present on Cinnamon desktop as well with default (Mint-X) theme.

@edbucks
Copy link

edbucks commented Jun 19, 2018

I set an appropriate theme for readable text via this environment variable on launch:

GTK_THEME=Adwaita:light easy-ebook-viewer

I hope this is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants