Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why you take only one person #127

Open
rafikg opened this issue Oct 18, 2019 · 1 comment
Open

Why you take only one person #127

rafikg opened this issue Oct 18, 2019 · 1 comment

Comments

@rafikg
Copy link

rafikg commented Oct 18, 2019

Hi @michalfaber

if len(persons) > 0:
main_person = persons[0]
main_person.masks_segments = masks
main_person.all_joints = JointsLoader.from_coco_keypoints(keypoints, w, h)
self.all_meta.append(main_person)

I am not sure here that I understand what you were doing. You process all the persons in each image and after some filters (areas, number of keypoints,...), you can get more than one persons in the persons list. However, you take only the first person (persons[0]) with all the keypoints (keypoints), but you throw the rest of the persons. At the end, it means we have only one bbox, one scale, one center but we have more than one person represented by (all_joints). It is really confusing! Could you explain, please?

@michalfaber
Copy link
Owner

Hi @deeperdeeper
The idea is that we sort visible persons by area - we got this information from the annotations. We skip a person if the distance to the previous one (in this sorted list) is too small. The COCO dataset contains keypoints of persons with quite a large scale difference, which is not handled well by the model. Taking only the most significant person in the image is the easiest simplification. Of course, there is an option to upscale other persons to reduce the problem of scale difference. I didn’t explore this path yet, but the code is ready for an additional preprocessing for each person in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants