Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator dots overlap app icons in gnome-shell 46.2 #2222

Closed
shelvaldes opened this issue May 27, 2024 · 28 comments · Fixed by #2315
Closed

Indicator dots overlap app icons in gnome-shell 46.2 #2222

shelvaldes opened this issue May 27, 2024 · 28 comments · Fixed by #2315
Assignees

Comments

@shelvaldes
Copy link

Fedora 40, the white dots that indicate an active app are overlapping the actual icon in any case. Here a screenshot.

white points dock

@andreglatz
Copy link

I have the same problem on Arch Linux with Gnome 46.2

image

@Calosis
Copy link

Calosis commented May 27, 2024

Same issue here on 46.2

@kenny-kelley
Copy link

May be related to previous a issue and fix: #2160 and #2168

I had this problem pre-v90 on any GNOME 46. It's back in GNOME 46.2 + Dash to Dock 92.

I'm also on Fedora 40 using the dnf package for Dash to Dock. 100% scaling on a 2560x1440, 27 inch monitor. Seeing similar behavior on my laptop's much smaller monitor too.

These are my settings:
Screenshot from 2024-05-27 14-57-13

Toggling on "Use built-in theme" definitely improves it.

@vrecek
Copy link

vrecek commented May 28, 2024

Screenshot from 2024-05-28 22-06-20

Same issue on Arch, 46.2, with/without custom shell theme.
While toggling "built-in theme" may solve the issue, this is not a solution for those, who want to apply a shell theme

@akashdiphazra
Copy link

akashdiphazra commented May 29, 2024

This thing appears after recent gnome-shell updates in fedora 40 or Gnome 46, toggling back indicators from square to dots fixes the issue.

@ghost
Copy link

ghost commented May 29, 2024

Same issue with Fedora 40. As @akashdiphazra said, changing from default (or, in his case, square) to dots (or any other option) fixed the issue.

You can find this option on the "appearence" page.
image

@kenny-kelley
Copy link

The "Dots" option is slightly different from "Default".

For example, "Default" does a single dot for applications that you have multiple windows of while "Dots" does multiple dots.

@GazimSoliev
Copy link

I have the same ui issue

@h1ac
Copy link

h1ac commented May 31, 2024

Changing this option to "Dots" instead of Default fixes it for me!
image

p5 added a commit to ublue-os/bluefin that referenced this issue Jun 1, 2024
@v9lu
Copy link

v9lu commented Jun 3, 2024

Same problem here, Fedora 40, Gnome Version 46

Also, I found helpful use Dots, but I found something wrong, and was right - when I compare old screenshot with "Default" and new screenshot with "Dots", the "Default" option looks small and better for me, so fix it pleaseeee :<

@pchmykh
Copy link

pchmykh commented Jun 3, 2024

Also built-in theme color mismatches with default system dock.

@vanvugt
Copy link
Collaborator

vanvugt commented Jun 4, 2024

It's a regression/feature in gnome-shell 46.2 so we just need to adapt...

6f215fa55d1ba477ca2c8950344a249742762c36 is the first bad commit
commit 6f215fa55d1ba477ca2c8950344a249742762c36
Author: Sebastian Keller <[email protected]>
Date:   Sun Mar 17 12:43:03 2024 +0100

    appDisplay: Set running indicator dot offset via CSS
    
    The offset was given as a hardcoded (physical) pixel value and did not
    take scaling into account. This lead to it being shifted closer towards
    the icon as the scale increased.
    
    This now replaces the hardcoded value with a CSS property which
    automatically includes the scale factor.
    
    Further this allows simplifying some calculations that previously were
    trying to counteract the hardcoded offset using margins by using the
    intended offset directly.
    
    With this the dot in the dash is also now placed at exactly the bottom
    of the hover highlight, while previously there was an unintentional 1px
    space.
    
    Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7488
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3245>
    (cherry picked from commit 31997fa2f9f3183d97c22f073e878b308331f288)

 data/theme/gnome-shell-sass/widgets/_app-grid.scss | 4 ++--
 data/theme/gnome-shell-sass/widgets/_dash.scss     | 2 +-
 js/ui/appDisplay.js                                | 7 ++++++-
 3 files changed, 9 insertions(+), 4 deletions(-)

@vanvugt
Copy link
Collaborator

vanvugt commented Jun 4, 2024

⬆️ Sound like fun, @sergio-costas ? Though I fear that backward compatibility will be a pain.

@sergio-costas
Copy link
Collaborator

I'll give it a check...

@vanvugt vanvugt changed the title White points overlap app icons Indicator dots overlap app icons in gnome-shell 46.2 Jun 12, 2024
@proninyaroslav
Copy link
Contributor

Is it possible to fix this?

@sergio-costas
Copy link
Collaborator

I have to check it, but I think that I have an idea.

@proninyaroslav
Copy link
Contributor

proninyaroslav commented Aug 16, 2024

@sergio-costas
I think if this can't be fixed, it should be removed, as it clearly doesn't work properly. A replacement would be to set the Dots as default, and add the ability to display one dot (regardless of the windows count). Or maybe just create a Dot (single dot) option.

@proninyaroslav
Copy link
Contributor

As a possible solution, I added an indicator with a single point, as similar as possible to the default indicator: #2265

@linesquarecube
Copy link

Thanks a lot for trying to fix this! Unfortunately, using 'dot' in v96 doesn’t change anything for me in Gnome 46.4 on Debian. The indicator is still stuck somewhere 'inside' the icon.
grafik
Only switching to 'Use Built-in Theme' helps, but it also breaks the whole look for me and causes unpinned applications to stay visible, even if they’re not running.
grafik
Anyway, I really appreciate you trying to fix this! :)

@proninyaroslav
Copy link
Contributor

proninyaroslav commented Sep 15, 2024

@linesquarecube
I'm using 46.4, but on Fedora with the default theme. Works fine. Have you tried using "Dots"? If "Dot" doesn't work for you, then "Dots" shouldn't work either, since it uses the same drawing, except that it draws one dot instead of multiple.

P.S: how "Dot" looks for me:
image

and how "Dots":
image

@linesquarecube
Copy link

linesquarecube commented Sep 16, 2024

@proninyaroslav I've tried all available options without any luck. Everything works as expected with the integrated theme. However, after some back-and-forth with the options, now all applications disappear when I deselect the integrated theme. I haven't changed anything else. I'm a bit confused right now 😕 Anyway, thanks for trying to help!

Using integrated theme:
grafik
Deselect the integrated theme:
Bildschirmfoto vom 2024-09-16 22-05-17

@proninyaroslav
Copy link
Contributor

@linesquarecube
Yes, something is definitely broken in the styles. Maybe there are other extensions that change the styles? For example, transparency.

@3v1n0
Copy link
Collaborator

3v1n0 commented Sep 24, 2024

This should have been fixed via #2285 and #2287

@3v1n0 3v1n0 closed this as completed Sep 24, 2024
@vanvugt vanvugt reopened this Sep 25, 2024
@vanvugt
Copy link
Collaborator

vanvugt commented Sep 25, 2024

Reopened. Sounds like @3v1n0 was commenting on the wrong bug there.

@linesquarecube
Copy link

linesquarecube commented Sep 25, 2024

@proninyaroslav The are three additional extension with influence on the look I have installed

I've already tried to deactivate and also uninstall the other extensions, unfortunately without any change.

Is there a possibility to clear all additional configuration caused by extensions? I do not fear to reconfigure them.

@proninyaroslav
Copy link
Contributor

@linesquarecube
You can use dconf editor and reset everything you need in the /org/gnome/shell/extensions/ branch and others.

@sergio-costas
Copy link
Collaborator

I'm testing it right now in a fresh-installed Fedora 40. After updating with DNF, it fails as indicated. I'll try to fix it.

imagen

@linesquarecube Can you enable the integrated theme, open a terminal, run journalctl -f, disable the integrated theme and copy/paste here the errors that (I presume) should appear in the terminal, please?

sergio-costas added a commit to sergio-costas/dash-to-dock that referenced this issue Oct 7, 2024
This patch fixes the dot in Default mode when not enabling "Few
customizations".

Tested in Ubuntu Noble, Fedora 46 (100% and 200% scale), and
Ubuntu Oracular (both in Ubuntu Desktop and Classic Gnome
sessions).

Fix: micheleg#2222
vanvugt pushed a commit that referenced this issue Oct 8, 2024
This patch fixes the dot in Default mode when not enabling "Few
customizations".

Tested in Ubuntu Noble, Fedora 46 (100% and 200% scale), and
Ubuntu Oracular (both in Ubuntu Desktop and Classic Gnome
sessions).

Closes: #2222
@proninyaroslav
Copy link
Contributor

#2315 tested on Fedora 40, works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.