Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made to build properly in VS2019 with JUCE static_cast in maximilian.cpp and change to return in maxiConvolve.cpp function float maxiConvolve::play(float w) #88

Open
mihailoradosavljevic opened this issue Apr 24, 2020 · 3 comments

Comments

@mihailoradosavljevic
Copy link

in maximilian.cpp line 1071
added static cast:

int fadeSize=min((unsigned long)100, static_cast(amplitudes.size()));

in maxiConvolve.cpp line 109:
//return ifft.process(&sumReal.front(), &sumImag.front(), maxiIFFT::COMPLEX);
return ifft.process(sumReal, sumImag, maxiIFFT::COMPLEX);

After those changes build was success, and everything works as expected.

@chriskiefer
Copy link
Collaborator

thanks we'll incorporate these fixes

@saha-dizel
Copy link

Hello!

Suggested fix at line 1071 in maximilian.cpp didn't work for me. I believe the reason to be lack of a type to cast to. The line below works in my case:

int fadeSize=min((unsigned long)100, static_cast<unsigned long>(amplitudes.size()));

@StuLast
Copy link

StuLast commented Aug 12, 2020

Proposed solution by @saha-dizel appears to work on Windows 10 x64 machine, Visual Studio 2019 + Juce Framework.

However, not sure static_cast is required as amplitudes is not a pointer. The following works well on my environment stated above. The code, though, does beg the question why the min comparison between 2 type longs is being stored in type int.

int fadeSize = min((unsigned long)100, (unsigned long)amplitudes.size());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants