-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importMetaPhlAn #688
Comments
Thanks, metaphlan outputs relative abundances so that could reflect the name. There is already a parameter to control the name, the default value could be changed (i.e. the name can be "relabundance" as we already use that naming somewhere) |
The difference is that The default name in the metaphlan importer could reflect that, it could be for instance "metaphlan". The examples could then explain and show how to transform that into [0,1] relative abundances if needed. |
"metaphlan" is also fine, as @Daenarys8 stated the most important thing is that people don't get confused |
Yes, "metaphlan" is pretty descriptive. Or it could be "metaphlan_relab". But perhaps just "metaphlan". Could you implement this @Daenarys8 ? |
The MetaPhlAn importer currently adds "counts," which could be easily confused with real counts or raw read data.
To improve clarity, I suggest renaming this output to "metaphlan" assay (or a similar label) to distinguish it from actual raw counts.
The text was updated successfully, but these errors were encountered: