Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importMetaPhlAn #688

Open
Daenarys8 opened this issue Feb 6, 2025 · 4 comments
Open

importMetaPhlAn #688

Daenarys8 opened this issue Feb 6, 2025 · 4 comments
Assignees

Comments

@Daenarys8
Copy link
Collaborator

The MetaPhlAn importer currently adds "counts," which could be easily confused with real counts or raw read data.
To improve clarity, I suggest renaming this output to "metaphlan" assay (or a similar label) to distinguish it from actual raw counts.

@Daenarys8 Daenarys8 assigned ake123 and unassigned ake123 Feb 6, 2025
@TuomasBorman
Copy link
Contributor

TuomasBorman commented Feb 6, 2025

Thanks, metaphlan outputs relative abundances so that could reflect the name. There is already a parameter to control the name, the default value could be changed (i.e. the name can be "relabundance" as we already use that naming somewhere)

@antagomir
Copy link
Member

The difference is that transformAssay(tse, method="relabundance") generates values in [0,1] whereas metaphlan data is often in [0,100]. It is also common that the values do not sum to 100 exactly, even if they get close to it. So this is somewhat different from what users typically expect from "relabundance" in standard (mia) pipelines.

The default name in the metaphlan importer could reflect that, it could be for instance "metaphlan". The examples could then explain and show how to transform that into [0,1] relative abundances if needed.

@TuomasBorman
Copy link
Contributor

"metaphlan" is also fine, as @Daenarys8 stated the most important thing is that people don't get confused

@antagomir
Copy link
Member

Yes, "metaphlan" is pretty descriptive. Or it could be "metaphlan_relab". But perhaps just "metaphlan".

Could you implement this @Daenarys8 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants