Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxplots significance #104

Closed
antagomir opened this issue Oct 18, 2023 · 8 comments
Closed

Boxplots significance #104

antagomir opened this issue Oct 18, 2023 · 8 comments

Comments

@antagomir
Copy link
Member

For examples with boxplots representing significance, the ggsnignif pkg is now supporting multiple testing correction:
const-ae/ggsignif#28 (comment)

-> Would be good to integrate to miaViz so that users can easily draw some standard comparisons that are readily corrected. Like alpha diversity or taxon abundance comparisons between groups for instance.

@muhamanz
Copy link

Thank you for your outstanding work on miaVIZ. The current plots from plotExpression can be cluttered and less informative. It would be immensely helpful to have more general plotting functions, such as those incorporating boxplots or violin plots. These additional plot types could better highlight significant species or taxa differences between study groups, especially in DAA analysis. For instance, a grouped boxplot could effectively highlight the significance of differences between study groups, offering a clearer and more informative representation of the data.

Thank you for considering this enhancement.

@antagomir
Copy link
Member Author

Related to #114 ?

@antagomir
Copy link
Member Author

I agree in general. The plots on this could be improved. I am also not a fan of violin plots.

@antagomir antagomir mentioned this issue May 16, 2024
@TuomasBorman
Copy link
Contributor

@muhamanz Now there is support for boxplots alanocallaghan/scater#208

devtools::install_github("alanocallaghan/scater")

library(mia)
library(scater)

data("GlobalPatterns")
tse <- GlobalPatterns

tse <- agglomerateByRank(tse, rank = "Phylum")
tse <- transformAssay(tse, method = "log10", pseudocount = 1)

# As a demonstration, take 5 first taxa
significant <- rownames(tse)[1:5]
plotExpression(tse, features = significant, assay.type = "log10", show_violin = FALSE, show_boxplot = TRUE)

@antagomir
Copy link
Member Author

Related to #41

@TuomasBorman
Copy link
Contributor

TuomasBorman commented Jul 23, 2024

I cannot find the PR/issue where I already commented last week, but ggsignif does not support multiple testing. Multiple testing correction was supported in a fork of ggsignif. The author of the fork then created a PR to ggsignif but they found problems in the implementation and it has not proceeded in almost a year. const-ae/ggsignif#133

However, this thing has been taken into account in current version of OMA. Instead of using ggsignif, it uses ggpubr. https://microbiome.github.io/OMA/docs/devel/pages/alpha_diversity.html#visualizing-significance-in-group-wise-comparisons

About creating a wrapper for this into miaViz... that would require quite a lot of work since we have to overwrite plotExpression/plotColData/plotRowData. Can you check if the example in OMA is enough?

@antagomir
Copy link
Member Author

Ok will have to check later. They might be sufficient indeed.

@TuomasBorman
Copy link
Contributor

This is solved with the example in OMA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants