Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break beta div into two computations #15

Open
d-callan opened this issue Feb 28, 2024 · 3 comments
Open

break beta div into two computations #15

d-callan opened this issue Feb 28, 2024 · 3 comments

Comments

@d-callan
Copy link
Contributor

From microbiomeComputations created by asizemore: VEuPathDB/microbiomeComputations#21

When revisiting how the app works, break up the compute into two very clear distinct parts. Prep for in the future when we might have only the first part of the current beta div app running

@asizemore
Copy link
Contributor

I'm working with beta div right now and am a little frustrated about only getting the pcoa outputs.
Did we have plans for how this would work? Some ideas in no particular order

  1. Extra arg to the beta div function that says give me distances or pcoa output
  2. Actually separate beta div into a beta div computation and a dimensionality reduction option
  3. Return both pcoa and distance matrix in the compute result. Distance matrix could go in stats i s'pose, similar to the correlation output.

@d-callan
Copy link
Contributor Author

those arent mutually exclusive. my suggestion, do all of the following:

  1. add a distanceMatrix method
  2. refactor the existing betaDiv method so it calls distanceMatrix
  3. add an arg to betaDiv so that it can optionally, additionally return distance matrix data in the stats slot

@d-callan
Copy link
Contributor Author

(how to organize it on the site, should we ever decide to let ppl plot the distance matrix directly, is less clear)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants