Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using ignoreImputeZeros was unclear #9

Open
asizemore opened this issue Aug 6, 2024 · 0 comments
Open

using ignoreImputeZeros was unclear #9

asizemore opened this issue Aug 6, 2024 · 0 comments

Comments

@asizemore
Copy link
Contributor

I went to pull a collection with and without imputing zeros, but how to do that puzzled me for a bit because I didn't know which way ignoreImputeZeros was going to go. Was it going to ignore what the collection said and impute zeros anyway, or the opposite? The code tells all of course, but i think we could improve the naming to make it so that users dont have to go to the code. How about imputeZerosOverride? Then true imputes zeros and false doesnt, regardless of what the collection says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant