Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure URLs returned are properly encoded #186

Open
aaronpk opened this issue Aug 1, 2018 · 0 comments
Open

Ensure URLs returned are properly encoded #186

aaronpk opened this issue Aug 1, 2018 · 0 comments

Comments

@aaronpk
Copy link
Member

aaronpk commented Aug 1, 2018

The change in #170 means it's possible to return URLs like http://example.com/foo bar with a space instead of the URL-encoded %20.

The parser should ensure all URLs returned are valid and escape any characters as appropriate. This should match the browser behavior of the browser making a request to http://example.com/foo%20bar when a link like <a href="http://example.com/foo bar">foo bar</a> is clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant