Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use Shade by default and package in another way for a runnable fatjar #236

Closed
ilopmar opened this issue Oct 29, 2021 · 3 comments
Closed
Labels
closed: duplicate This issue or pull request already exists type: enhancement New feature or request

Comments

@ilopmar
Copy link
Contributor

ilopmar commented Oct 29, 2021

We shouldn't package the application by default (mvn package) using the Shade plugin, instead we should create only the application jar. The usage of the Shade plugin should be enabled under a flag -Pshade.

This also makes that we need a way to create runnable fatjars. Explore different options like https://www.baeldung.com/executable-jar-with-maven

@ilopmar ilopmar added the type: enhancement New feature or request label Oct 29, 2021
@shirishpandharikar
Copy link

Something similar to One Jar will be so much better. One Jar unfortunately doesn't seem to be maintained anymore but I've tried the Maven plugin and it works.

@alvarosanchez
Copy link
Member

Relates to: #123

@alvarosanchez alvarosanchez added the closed: duplicate This issue or pull request already exists label Mar 20, 2022
@alvarosanchez
Copy link
Member

Actually duplicates #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: duplicate This issue or pull request already exists type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants