Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SETOF support #11

Open
GrandFelix opened this issue Jun 28, 2018 · 3 comments
Open

SETOF support #11

GrandFelix opened this issue Jun 28, 2018 · 3 comments

Comments

@GrandFelix
Copy link

Is possible to get SETOF support

@sachaarbonel
Copy link
Contributor

I don't have the necessity for SETOF for the moment in my project but I was searching informations about the subject I found this and this

@GrandFelix
Copy link
Author

Is here something new maybe? 😇

@microo8
Copy link
Owner

microo8 commented Dec 7, 2019

So the SETOF functionality isn't just eg. a function that returns an array
You cannot write something like:

func FibonacciSETOF(n int) []int {
    f := make([]int, n+1, n+2)
    if n < 2 {
        f = f[0:2]
    }
    f[0] = 0
    f[1] = 1
    for i := 2; i <= n; i++ {
        f[i] = f[i-1] + f[i-2]
    }
    return f
}

and expect it to be a SETOF returning function.
These functions are written so, that it is called multiple times and every time it receives the user "context" and information of where it is in the "SET" .
https://www.postgresql.org/docs/current/xfunc-c.html#XFUNC-C-RETURN-SET

It is possible to split the function to these calls. something like:

//returning the data to be stored in context and the maximum number of calls
func FibonacciSETOFInit(n int) (interface{}, int) {
    f := make([]int, n+1, n+2)
    if n < 2 {
        f = f[0:2]
    }
    f[0] = 0
    f[1] = 1
    return f, n
}

//this function will be called n-times
//getting the context, with the data and iteration number
func FibonacciSETOFNext(ctx plgo.Context) int {
    f := ctx.Value().([]int)
    f[ctx.Iteration()] = f[ctx.Iteration()-1] + f[ctx.Iteration()-2]
    return f[ctx.Iteration()]
}

so if you call select fibonacci(10) plgo will generate the function where the first time it will call FibonacciSETOFInit and then 10 times FibonacciSETOFNext.

There is a user_fctx pointer, to user defined data, that are allocated in the "init" phase and then used in the function calls. The problem is, that memory controlled by go, cannot be passed to C. So this context cannot be used by plgo.

And if it is somehow possible, writing something like this is complicated.
So maybe it is better to just write a function returning an array and then call it with unnest: select unnest(Fibonacci(10))
Any ideas what to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants