Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Consider renaming AZURE_STORAGE_CONN_STRING to AZURE_STORAGE_CONNECTION_STRING #14

Open
rrnewton opened this issue Dec 14, 2018 · 2 comments
Labels
Design Change Request Request to change the current design

Comments

@rrnewton
Copy link
Contributor

This is a migration of VSTS 127.

Existing Azure CLI tools use AZURE_STORAGE_CONNECTION_STRING, so it would be good to standardize on that and avoid confusion.

For backwards compatibility with the existing AMBROSIA release, it could look for both and use the current "CONN" version if "CONNECTION" is not found.

@darrenge darrenge added the Design Change Request Request to change the current design label Dec 18, 2018
@lovettchris
Copy link
Member

Better still, AZURE_STORAGE_CONNECTION_STRING is way too general it should be called "AMBROSIA_STORAGE_CONNECTION_STRING"

@rrnewton
Copy link
Contributor Author

Agreed that this is more general and also more hygienic.

But is there a scenario where one would want to have the azure CLI talk to one AZURE_STORAGE_CONNECTION_STRING, and have ambrosia use a different AMBROSIA_STORAGE_CONNECTION_STRING?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Design Change Request Request to change the current design
Projects
None yet
Development

No branches or pull requests

3 participants