Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

GetLocalIPAddress is not general enough. #88

Open
lovettchris opened this issue Jul 26, 2019 · 0 comments
Open

GetLocalIPAddress is not general enough. #88

lovettchris opened this issue Jul 26, 2019 · 0 comments

Comments

@lovettchris
Copy link
Member

lovettchris commented Jul 26, 2019

ImmortalCoordinator has this method GetLocalIPAddress which is handy, but not correct in the case where a computer has multiple ethernet interfaces (e.g. wired and wireless). In this case the user may want to specify which interface to use since they know which one is connected to the right network. You could also provide a better default which tests all available interfaces to figure out which one can reach Azure storage.

Note that CRA gets it right with CRA.Worker.exe where "An optional third parameter can be used to provide an explicit IP address."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant