Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Linked:Bug3397279}[Adaptive Cards > Designer] - The menu item appears after expanding the 'Add an action' button is not accessible with keyboard. #8826

Closed
vagpt opened this issue Feb 9, 2024 · 8 comments · Fixed by #8888
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance AdaptiveCards_Web a11y tag Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC

Comments

@vagpt
Copy link
Collaborator

vagpt commented Feb 9, 2024

Target Platforms

Other

SDK Version

1.6

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io/designer/
OS Version: 23H2 (OS Build 26040.1000)
Browser Version: Version 122.0.2365.3 (Official build) dev (64-bit)
Screen Reader: Narrator

Repro Steps:

  1. Open the above URL on Edge Dev URL.
  2. Press tab key and navigate to the 'New Card' and press enter key to activate it.
  3. New Card dialog will be appeared.
  4. Navigate to the 'Blank Card' using tab key and press enter key to activate it.
  5. Navigate to the 'Add an Action' button and press enter key to activate it.
  6. Press tab or arrow key and observe the issue.

Actual Result:
The menu item appears after expanding the 'Add an action' button is not accessible with keyboard, on pressing down arrow key focus does not move inside the menu items and after pressing tab key focus moves to the next control and the menu item remains expanded.

Expected Result:
The menu item appears after expanding the 'Add an action' button should be accessible with keyboard up/down arrow keys and after pressing tab focus should land on next control and the menu item should collapse.

Note:
After adding any item from the add an action with mouse a clear button appears which is not accessible with keyboard

User Experience:
If menu items and clear button will not be accessible with keyboard, then the users dependent on the keyboard will be unable to access the UI properly and may face trouble.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/keyboard

Have feedback to share on Bugs ? please tag bug as “A11yRCA” and add your feedback in the comment section

Screenshots

The menu item appears after expanding the 'Add an action' button is not accessible with keyboard

The.menu.item.appears.after.expanding.the.Add.an.action.button.is.not.accessible.with.keyboard.mp4

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vagpt vagpt added Bug Area-Renderers Area-Accessibility Bugs around feature accessibility A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yWCAG Accessibility issue that affects compliance HCL-E+D Product-AC HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization labels Feb 9, 2024
@vagpt
Copy link
Collaborator Author

vagpt commented Feb 27, 2024

Hi @anna-dingler,

Any update about this bug?

@anna-dingler
Copy link
Contributor

Hi @vagpt,

I do not have any updates on this bug. At this time, my team doesn't have the bandwidth to resolve this issue ahead of schedule. It is currently budgeted for our April sprint.

Thanks,
Anna

@vagpt
Copy link
Collaborator Author

vagpt commented May 17, 2024

Hi @anna-dingler,

This issue is still repro at our end on the environment below, hence reactivating this issue.

Test Environment:
URL: https://adaptivecards.io/designer/
OS Version: 24H2 (OS Build 26090.1000)
Browser Version: Version 126.0.2566.1 (Official build) dev (64-bit)
Keyboard: Logitech K480

Attachment:

AC.-.menu.items.are.not.accessible.yet.mp4

@vagpt vagpt reopened this May 17, 2024
@anna-dingler
Copy link
Contributor

Hi @vagpt, this fix is pending release on our site. I'll add the appropriate tag - apologies for the confusion.

@anna-dingler anna-dingler added the NotReadyToTest Label to indicate that this issue has been resolved, but the fix has not been released. label May 17, 2024
@vagpt
Copy link
Collaborator Author

vagpt commented Jun 25, 2024

Hi @anna-dingler,

Hope you are doing great.

As this issue is still repro'ing at our end so could you please let us know by when the changes will be merged on the site.

@anna-dingler anna-dingler removed the NotReadyToTest Label to indicate that this issue has been resolved, but the fix has not been released. label Jun 27, 2024
@vagpt
Copy link
Collaborator Author

vagpt commented Jul 9, 2024

Hi @anna-dingler,

Hope you are doing good.

Any update on this issue as this is hitting the dependent team SLA?

@anna-dingler
Copy link
Contributor

Hi @vagpt,

This issue has been resolved, and the fix has been released both on the website and in our JS package.

@vagpt
Copy link
Collaborator Author

vagpt commented Jul 15, 2024

This issue is working fine on the environment below, hence closing this issue.

Test Environment:
URL: https://adaptivecards.io/designer/
OS Version: 24H2 (OS Build 26244.5000)
Browser Version: Version 128.0.2690.3 (Official build) dev (64-bit)

Attachment:

Untitled.video.-.Made.with.Clipchamp.44.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance AdaptiveCards_Web a11y tag Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants