Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A loading icon appears in the preview editor of a csv file if empty the 'Skip rows' field #8424

Closed
v-xianya opened this issue Jan 10, 2025 · 4 comments
Assignees
Labels
🧪 testing Found through regular testing
Milestone

Comments

@v-xianya
Copy link
Member

Storage Explorer Version: 1.37.0-dev (103)
Build Number: 20250110.2
Branch: main
Platform/OS: Windows 11/Windows11/Linux Ubuntu 22.04/MacOS Sequoia 15.2(Apple M1 Pro)
Architecture: x64/arm64/x64/arm64
How Found: Exploratory testing
Regression From: Not a regression

Steps to Reproduce

  1. Expand one storage account -> Blob Containers.
  2. Create a blob container -> Upload one csv file.
  3. Preview the csv file -> Empty the 'Skip rows' -> Press 'Enter'.
  4. Check whether the preview editor shows well.

Expected Experience

The preview editor shows well.

Actual Experience

A loading icon appears in the preview editor.
Image

@v-xianya v-xianya added the 🧪 testing Found through regular testing label Jan 10, 2025
@craxal craxal self-assigned this Jan 10, 2025
@craxal craxal added this to the 1.38.0 milestone Jan 10, 2025
@craxal
Copy link
Contributor

craxal commented Jan 23, 2025

This was caused by the progress indicator always being turned on when an input change was detected, but a parse would not happen if the parameters ended up unmodified (for example, the skip count was unmodified). Since no parse would occur, the code that turns off the progress indicator wasn't being triggered. This is fixed by only turning on the progress indicator if actual changes to the parse parameters are encountered.

@craxal craxal closed this as completed Jan 23, 2025
@v-xianya
Copy link
Member Author

Hi @craxal Verified this issue on the main build 20250124.1. Reproduces. So, we are going to reopen this issue.

@v-xianya v-xianya reopened this Jan 24, 2025
@craxal
Copy link
Contributor

craxal commented Jan 28, 2025

Should be fixed now. If not, please provide details on repro steps.

@craxal craxal closed this as completed Jan 28, 2025
@v-xianya
Copy link
Member Author

v-xianya commented Feb 5, 2025

Verified this issue on the main build 20250131.1. Fixed. The 'Skip rows' field will be filled with '0' if trying to empty it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 testing Found through regular testing
Projects
None yet
Development

No branches or pull requests

2 participants