Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of cookies to the Rest Client module #989

Open
1 task done
ajkauffmann opened this issue Apr 25, 2024 · 1 comment
Open
1 task done

Add support of cookies to the Rest Client module #989

ajkauffmann opened this issue Apr 25, 2024 · 1 comment
Assignees
@ajkauffmann
Labels
Approved The issue is approved Integration GitHub request for Integration area

Comments

@ajkauffmann
Copy link
Contributor

Describe the issue

Version v24 adds support for cookies to the HTTP calls. The Rest Client module currently doesn't support this.

Expected behavior

The Rest Client module should also support adding and reading cookies.

Steps to reproduce

The Rest Client module has no functions to add or read cookies.

Additional context

The Rest Client module supports working directly with the underlying HttpClient, and the HttpRequestMessage and HttpResponseMessage. In that way, cookies are supported. But it would be more developer-friendly if the module itself exposes functions to work with cookies.

I will provide a fix for a bug

  • I will provide a fix for a bug
@ajkauffmann ajkauffmann added the Bug Something isn't working label Apr 25, 2024
@JesperSchulz JesperSchulz added the Approved The issue is approved label Apr 25, 2024
@JesperSchulz
Copy link
Contributor

Of course approved!

@aholstrup1 aholstrup1 mentioned this issue May 1, 2024
Closed
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 16, 2024
@aholstrup1 aholstrup1 removed the Bug Something isn't working label Nov 27, 2024
@ajkauffmann ajkauffmann mentioned this issue Dec 9, 2024
Merged
JesperSchulz added a commit that referenced this issue Dec 20, 2024
@ajkauffmann @JesperSchulz
[Rest Client] Support for Cookies + Fix secret headers + Collectible …
8f215cb 
…errors (#2474)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Adding support for cookies to the Rest Client
Fixing an issue with secret headers
Adding collectible error behavior
Redesigning internal code for better maintainability and uptaking new AL
features like the keyword `this`

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #1479 #989 


Fixes
[AB#560010](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/560010)

---------

Co-authored-by: Jesper Schulz-Wedde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajkauffmann ajkauffmann

Labels
Approved The issue is approved Integration GitHub request for Integration area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajkauffmann @JesperSchulz @aholstrup1