From 2fcc7fa564d89a64c13755d295ca2ff401dd8962 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Mon, 4 Mar 2024 20:13:29 -0800 Subject: [PATCH] Make it work, kinda --- packages/eslint-plugin/src/rules/expect.ts | 18 ++++++++-------- .../expect-tsconfigs/expect-dom-tests.ts.lint | 8 +++++++ .../expect-tsconfigs/expect-tests.ts.lint | 15 +++++++++++++ .../types/expect-tsconfigs/index.d.ts.lint | 12 +++++++++++ .../types/expect-tsconfigs/.eslintrc.json | 8 +++++++ .../expect-tsconfigs/expect-dom-tests.ts | 4 ++++ .../types/expect-tsconfigs/expect-tests.ts | 4 ++++ .../types/expect-tsconfigs/index.d.ts | 1 + .../types/expect-tsconfigs/package.json | 5 +++++ .../types/expect-tsconfigs/tsconfig.dom.json | 20 ++++++++++++++++++ .../types/expect-tsconfigs/tsconfig.json | 21 +++++++++++++++++++ .../expect-tsconfigs/tsconfig.no-dom.json | 19 +++++++++++++++++ 12 files changed, 126 insertions(+), 9 deletions(-) create mode 100644 packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-dom-tests.ts.lint create mode 100644 packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-tests.ts.lint create mode 100644 packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/index.d.ts.lint create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/.eslintrc.json create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-dom-tests.ts create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-tests.ts create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/index.d.ts create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/package.json create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.dom.json create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.json create mode 100644 packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.no-dom.json diff --git a/packages/eslint-plugin/src/rules/expect.ts b/packages/eslint-plugin/src/rules/expect.ts index 48a83ca8db..7053bf73f3 100644 --- a/packages/eslint-plugin/src/rules/expect.ts +++ b/packages/eslint-plugin/src/rules/expect.ts @@ -69,10 +69,10 @@ Then re-run.`, reportDiagnostics = false; } - const tsconfigs = ["tsconfig.json"]; + let tsconfigs: readonly string[] = ["tsconfig.json"]; let reportTsconfigName = false; - if (settings.extraTsconfigs) { - tsconfigs.push(...settings.extraTsconfigs); + if (settings.tsconfigs) { + tsconfigs = settings.tsconfigs; reportTsconfigName = true; } @@ -148,7 +148,7 @@ interface VersionToTest { interface Settings { readonly versionsToTest?: readonly VersionToTest[]; - readonly extraTsconfigs?: readonly string[]; + readonly tsconfigs?: readonly string[]; } function getSettings(context: Parameters<(typeof rule)["create"]>[0]): Settings { @@ -168,18 +168,18 @@ function getSettings(context: Parameters<(typeof rule)["create"]>[0]): Settings } } - const extraTsconfigs = (dt as Record).extraTsconfigs ?? undefined; - if (extraTsconfigs !== undefined && !Array.isArray(extraTsconfigs)) { - throw new Error("Invalid extraTsconfigs"); + const tsconfigs = (dt as Record).tsconfigs ?? undefined; + if (tsconfigs !== undefined && !Array.isArray(tsconfigs)) { + throw new Error("Invalid tsconfigs"); } - for (const tsconfig of extraTsconfigs ?? []) { + for (const tsconfig of tsconfigs ?? []) { if (typeof tsconfig !== "string") { throw new Error("Invalid extra tsconfig"); } } - return { versionsToTest, extraTsconfigs }; + return { versionsToTest, tsconfigs }; } const programCache = new WeakMap>(); diff --git a/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-dom-tests.ts.lint b/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-dom-tests.ts.lint new file mode 100644 index 0000000000..e49f35d410 --- /dev/null +++ b/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-dom-tests.ts.lint @@ -0,0 +1,8 @@ +No errors + +==== types/expect-tsconfigs/expect-dom-tests.ts ==== + + // eslint-disable-next-line @definitelytyped/no-relative-import-in-test + import * as expect from "./"; + + const element: HTMLElement = expect.element; diff --git a/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-tests.ts.lint b/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-tests.ts.lint new file mode 100644 index 0000000000..195d4a9a38 --- /dev/null +++ b/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/expect-tests.ts.lint @@ -0,0 +1,15 @@ +types/expect-tsconfigs/expect-tests.ts + 4:16 error TypeScript@x.y:tsconfig.no-dom.json compile error: +Cannot find name 'HTMLElement' @definitelytyped/expect + +✖ 1 problem (1 error, 0 warnings) + +==== types/expect-tsconfigs/expect-tests.ts ==== + + // eslint-disable-next-line @definitelytyped/no-relative-import-in-test + import * as expect from "./"; + + const element: HTMLElement = expect.element; + ~~~~~~~~~~~ +!!! @definitelytyped/expect: TypeScript@x.y:tsconfig.no-dom.json compile error: +!!! : Cannot find name 'HTMLElement'. diff --git a/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/index.d.ts.lint b/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/index.d.ts.lint new file mode 100644 index 0000000000..7737511a5d --- /dev/null +++ b/packages/eslint-plugin/test/__file_snapshots__/types/expect-tsconfigs/index.d.ts.lint @@ -0,0 +1,12 @@ +types/expect-tsconfigs/index.d.ts + 1:23 error TypeScript@x.y:tsconfig.no-dom.json compile error: +Cannot find name 'HTMLElement' @definitelytyped/expect + +✖ 1 problem (1 error, 0 warnings) + +==== types/expect-tsconfigs/index.d.ts ==== + + export const element: HTMLElement; + ~~~~~~~~~~~ +!!! @definitelytyped/expect: TypeScript@x.y:tsconfig.no-dom.json compile error: +!!! : Cannot find name 'HTMLElement'. diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/.eslintrc.json b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/.eslintrc.json new file mode 100644 index 0000000000..46231e2614 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/.eslintrc.json @@ -0,0 +1,8 @@ +{ + "settings": { + "dt": { + "versionsToTest": [{ "versionName": "x.y", "path": "typescript" }], + "tsconfigs": ["tsconfig.dom.json", "tsconfig.no-dom.json"] + } + } +} diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-dom-tests.ts b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-dom-tests.ts new file mode 100644 index 0000000000..151b93d909 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-dom-tests.ts @@ -0,0 +1,4 @@ +// eslint-disable-next-line @definitelytyped/no-relative-import-in-test +import * as expect from "./"; + +const element: HTMLElement = expect.element; diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-tests.ts b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-tests.ts new file mode 100644 index 0000000000..151b93d909 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/expect-tests.ts @@ -0,0 +1,4 @@ +// eslint-disable-next-line @definitelytyped/no-relative-import-in-test +import * as expect from "./"; + +const element: HTMLElement = expect.element; diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/index.d.ts b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/index.d.ts new file mode 100644 index 0000000000..d5643da83d --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/index.d.ts @@ -0,0 +1 @@ +export const element: HTMLElement; diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/package.json b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/package.json new file mode 100644 index 0000000000..0c26dbf768 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/package.json @@ -0,0 +1,5 @@ +{ + "name": "@types/expect", + "version": "2.0.9999", + "owners": [] +} diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.dom.json b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.dom.json new file mode 100644 index 0000000000..c89832eae5 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.dom.json @@ -0,0 +1,20 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6", + "dom" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictFunctionTypes": true, + "strictNullChecks": true, + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "expect-dom-tests.ts" + ] +} diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.json b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.json new file mode 100644 index 0000000000..a2f256cde2 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.json @@ -0,0 +1,21 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6", + "dom" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictFunctionTypes": true, + "strictNullChecks": true, + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "expect-tests.ts", + "expect-dom-tests.ts" + ] +} diff --git a/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.no-dom.json b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.no-dom.json new file mode 100644 index 0000000000..e5dfa2b823 --- /dev/null +++ b/packages/eslint-plugin/test/fixtures/types/expect-tsconfigs/tsconfig.no-dom.json @@ -0,0 +1,19 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictFunctionTypes": true, + "strictNullChecks": true, + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "expect-tests.ts" + ] +}