From 6f2691c726f911ce0d288a1d6854c9885cc52a5a Mon Sep 17 00:00:00 2001 From: gopalrs <33950290+gopalrs@users.noreply.github.com> Date: Tue, 15 Oct 2024 17:33:49 +0530 Subject: [PATCH] Fix the code hang while caching nodes if search is run with a single thread (#590) * Fixing other places with the single search thread hang issue * Fixing other places with the single search thread hang issue * Adding overwrite option to delete old versions * Add a run id to files to avoid naming conflicts --------- Co-authored-by: Gopal Srinivasa --- .github/workflows/build-python-pdoc.yml | 3 ++- src/pq_flash_index.cpp | 5 ----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-python-pdoc.yml b/.github/workflows/build-python-pdoc.yml index 96c729605..444a7ee6e 100644 --- a/.github/workflows/build-python-pdoc.yml +++ b/.github/workflows/build-python-pdoc.yml @@ -47,7 +47,8 @@ jobs: with: name: dependencies path: | - dependencies_documentation.txt + ${{ github.run_id }}-dependencies_documentation.txt + overwrite: true - name: Archive documentation artifacts uses: actions/upload-artifact@v4 with: diff --git a/src/pq_flash_index.cpp b/src/pq_flash_index.cpp index fbb81d55f..d9ad50617 100644 --- a/src/pq_flash_index.cpp +++ b/src/pq_flash_index.cpp @@ -365,11 +365,6 @@ void PQFlashIndex::cache_bfs_levels(uint64_t num_nodes_to_cache, std: } diskann::cout << "Caching " << num_nodes_to_cache << "..." << std::endl; - // borrow thread data - ScratchStoreManager> manager(this->_thread_data); - auto this_thread_data = manager.scratch_space(); - IOContext &ctx = this_thread_data->ctx; - std::unique_ptr> cur_level, prev_level; cur_level = std::make_unique>(); prev_level = std::make_unique>();