From a0114e009b010dc710cf2b38c1e673b235c08775 Mon Sep 17 00:00:00 2001 From: gopalrs <33950290+gopalrs@users.noreply.github.com> Date: Fri, 6 Dec 2024 21:37:50 +0530 Subject: [PATCH 1/5] Upload data and bin even if a run fails. --- .github/workflows/dynamic-labels.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dynamic-labels.yml b/.github/workflows/dynamic-labels.yml index d5dc7122b..6b8bc94f2 100644 --- a/.github/workflows/dynamic-labels.yml +++ b/.github/workflows/dynamic-labels.yml @@ -94,6 +94,7 @@ jobs: dist/bin/search_memory_index --data_type float --dist_fn l2 --fail_if_recall_below 70 --index_path_prefix data/index_rand_ins_del.after-concurrent-delete-del2500-7500 --result_path res_stream --query_file data/rand_float_10D_1K_norm1.0.bin --gt_file data/gt100_rand_random10D_1K -K 10 -L 20 40 60 80 100 -T 64 - name: upload data and bin + if: success() || failure() uses: actions/upload-artifact@v4 with: name: dynamic-labels-${{matrix.os}} From a6f708d4a3786a57b60440171f9dc7d3eedebf48 Mon Sep 17 00:00:00 2001 From: gopalrs <33950290+gopalrs@users.noreply.github.com> Date: Fri, 6 Dec 2024 21:58:06 +0530 Subject: [PATCH 2/5] Update dynamic.yml --- .github/workflows/dynamic.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dynamic.yml b/.github/workflows/dynamic.yml index edd691ef7..0b79aacca 100644 --- a/.github/workflows/dynamic.yml +++ b/.github/workflows/dynamic.yml @@ -67,6 +67,7 @@ jobs: dist/bin/search_memory_index --data_type uint8 --dist_fn l2 --fail_if_recall_below 70 --index_path_prefix data/index_ins_del.after-concurrent-delete-del2500-7500 --result_path data/res_ins_del --query_file data/rand_uint8_10D_1K_norm50.0.bin --gt_file data/gt100_random10D_10K-conc-2500-7500 -K 10 -L 20 40 60 80 100 -T 8 --dynamic true --tags 1 - name: upload data and bin + if: success() || failure() uses: actions/upload-artifact@v4 with: name: dynamic-${{matrix.os}} From 597ec464fd1372d9d7b8523750d947fed2a0c6c8 Mon Sep 17 00:00:00 2001 From: gopalrs <33950290+gopalrs@users.noreply.github.com> Date: Fri, 6 Dec 2024 23:53:30 +0530 Subject: [PATCH 3/5] Update dynamic.yml --- .github/workflows/dynamic.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/dynamic.yml b/.github/workflows/dynamic.yml index 0b79aacca..88e6158d9 100644 --- a/.github/workflows/dynamic.yml +++ b/.github/workflows/dynamic.yml @@ -23,6 +23,13 @@ jobs: with: fetch-depth: 1 submodules: true + - name: Configure Windows to Generate Crash Dumps + run: | + reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /f + reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpFolder /t REG_EXPAND_SZ /d "%SystemDrive%\\CrashDumps" /f + reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpCount /t REG_DWORD /d 10 /f + reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpType /t REG_DWORD /d 2 /f + - name: DiskANN Build CLI Applications uses: ./.github/actions/build From b09b0992b1f80b48270a473423a37d3526d312a3 Mon Sep 17 00:00:00 2001 From: gopalrs <33950290+gopalrs@users.noreply.github.com> Date: Sat, 7 Dec 2024 14:29:35 +0530 Subject: [PATCH 4/5] Fix Windows crash dump configuration in workflow --- .github/workflows/dynamic.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/dynamic.yml b/.github/workflows/dynamic.yml index 88e6158d9..c4230b88e 100644 --- a/.github/workflows/dynamic.yml +++ b/.github/workflows/dynamic.yml @@ -25,10 +25,10 @@ jobs: submodules: true - name: Configure Windows to Generate Crash Dumps run: | - reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /f - reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpFolder /t REG_EXPAND_SZ /d "%SystemDrive%\\CrashDumps" /f - reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpCount /t REG_DWORD /d 10 /f - reg add "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps" /v DumpType /t REG_DWORD /d 2 /f + reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows\ Error\ Reporting\\LocalDumps //f + reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows\ Error\ Reporting\\LocalDumps //v DumpFolder //t REG_EXPAND_SZ //d "./dist" //f + reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows Error Reporting\\LocalDumps" //v DumpCount //t REG_DWORD //d 10 //f + reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows Error Reporting\\LocalDumps" //v DumpType //t REG_DWORD //d 2 //f - name: DiskANN Build CLI Applications uses: ./.github/actions/build From 228c2f3dc05c843d1d774c787c7e1cc1b9ba023e Mon Sep 17 00:00:00 2001 From: gopalrs <33950290+gopalrs@users.noreply.github.com> Date: Sat, 7 Dec 2024 15:19:31 +0530 Subject: [PATCH 5/5] Fixed syntax errors in reg command for crash dump generation. Added an OS check too --- .github/workflows/dynamic.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dynamic.yml b/.github/workflows/dynamic.yml index c4230b88e..a86770076 100644 --- a/.github/workflows/dynamic.yml +++ b/.github/workflows/dynamic.yml @@ -24,11 +24,12 @@ jobs: fetch-depth: 1 submodules: true - name: Configure Windows to Generate Crash Dumps + if: ${{ runner.os == 'Windows' }} run: | reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows\ Error\ Reporting\\LocalDumps //f reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows\ Error\ Reporting\\LocalDumps //v DumpFolder //t REG_EXPAND_SZ //d "./dist" //f - reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows Error Reporting\\LocalDumps" //v DumpCount //t REG_DWORD //d 10 //f - reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows Error Reporting\\LocalDumps" //v DumpType //t REG_DWORD //d 2 //f + reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows\ Error\ Reporting\\LocalDumps" //v DumpCount //t REG_DWORD //d 10 //f + reg add HKLM\\SOFTWARE\\Microsoft\\Windows\\Windows\ Error\ Reporting\\LocalDumps" //v DumpType //t REG_DWORD //d 2 //f - name: DiskANN Build CLI Applications uses: ./.github/actions/build