Code gardening (#283)

microsoft · May 30, 2023 · 919faae · 919faae
1 parent b20660e
commit 919faae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/Microsoft.Unity.Analyzers/BaseVectorConversion.cs b/src/Microsoft.Unity.Analyzers/BaseVectorConversion.cs
@@ -15,7 +15,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Operations;
-using Microsoft.CodeAnalysis.Simplification;
 
 namespace Microsoft.Unity.Analyzers;
 

diff --git a/src/Microsoft.Unity.Analyzers/ScriptInfo.cs b/src/Microsoft.Unity.Analyzers/ScriptInfo.cs
@@ -71,14 +71,13 @@ public IEnumerable<MethodInfo> GetNotImplementedMessages(Accessibility? accessib
 
 	private static bool AccessibilityMatch(MethodInfo message, Accessibility accessibility)
 	{
-		// If the message is declared as public or protected we need to honor it, other messages can be anything
-		if (message.IsPublic && message.IsVirtual)
-			return accessibility == Accessibility.Public;
-
-		if (message.IsFamily && message.IsVirtual)
-			return accessibility == Accessibility.Protected;
-
-		return true;
+		return message switch
+		{
+			// If the message is declared as public or protected we need to honor it, other messages can be anything
+			{ IsPublic: true, IsVirtual: true } => accessibility == Accessibility.Public,
+			{ IsFamily: true, IsVirtual: true } => accessibility == Accessibility.Protected,
+			_ => true
+		};
 	}
 
 	private bool IsImplemented(MethodInfo method)