Fix missing imports due to pylance thinking open documents are under default workspace #8033
+38
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bschnurr
commented
Oct 21, 2024
bschnurr
commented
- inject workspace definitions into the "initialize" call to pylance so that there is no chance of a textdocument/didopen call triggering the creation of a dfeault workspace before getfolders is called to setup the workspace.
… we wont be creating a default workspace if textdocument/didopen is sent before workspacefolders are updated
rchiodo
reviewed
Oct 21, 2024
| @@ -593,24 +590,35 @@ private Tuple<StreamData, bool> OnSendToServer(StreamData data) { | |||
| return Tuple.Create(data, true); | |||
| } | |||
|
|
|||
| private async Task OnWorkspaceOpening(object sende, EventArgs e) { | |||
| private IEnumerable<WorkspaceFolder> GetFolders() { | |||
There was a problem hiding this comment.
Could you have this always return a list? Every place you call it you're turning it into a list.
There was a problem hiding this comment.
true. such a small list. no reason to make it enumerable
rchiodo
approved these changes
Oct 21, 2024
bschnurr
commented
Oct 21, 2024
| @@ -138,7 +135,7 @@ public async Task<Connection> ActivateAsync(CancellationToken token) { | |||
| await JoinableTaskContext.Factory.SwitchToMainThreadAsync(); | |||
| CreateClientContexts(); | |||
|
|
|||
| _deferredSettingsChangedTimer = new Timer(OnDeferredSettingsChanged, state: null, Timeout.Infinite, Timeout.Infinite); | |||
There was a problem hiding this comment.
just replacing this function with a lamda to cut down on fuctions
bschnurr
commented
Oct 21, 2024
| return InvokeDidChangeConfigurationAsync(new LSP.DidChangeConfigurationParams() { | ||
| // Pylance will ask us for per workspace configuration settings. We can send | ||
| // default workspace settings here. | ||
| Settings = GetSettings() |
There was a problem hiding this comment.
now include actual settings which get applied to any default workspace
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.