Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ISOs not parsed from DiscUtils #9

Open
PrzemyslawKlys opened this issue Aug 5, 2020 · 11 comments
Open

Some ISOs not parsed from DiscUtils #9

PrzemyslawKlys opened this issue Aug 5, 2020 · 11 comments
Labels
bug Something isn't working external A bug in a library Recursive Extractor depends on

Comments

@PrzemyslawKlys
Copy link

I've been playing with this library for a few minutes and created small PowerShell module using it.

$ExtractMe = "$Env:UserProfile\Downloads\DaRT70.iso"
$Extractor = [Microsoft.CST.OpenSource.RecursiveExtractor.Extractor]::new()
$Extractor.ExtractFile($ExtractMe) | Format-Table

this is the error:
image

This is bootable .iso.

@gfs
Copy link
Contributor

gfs commented Aug 6, 2020

Thanks for your report. That its unusual since it looks like you are on Windows.

Can you possibly provide the target file you're using?

@gfs gfs added the bug Something isn't working label Aug 6, 2020
@PrzemyslawKlys
Copy link
Author

PrzemyslawKlys commented Aug 6, 2020

Unfortunately can't. This is from Dart from MS, but it's a private build.

But it would seem.ISO files aren't working properly:

image

Tar files behave differently

image

And also I am not sure if FullPath is what I would expect - why would there be ; and why would it reverse slash for files inside .tar? I guess it sees it like that inside .tar but maybe it should normalize it for Windows since I'm on Windows?

@gfs
Copy link
Contributor

gfs commented Aug 6, 2020

This is from Dart from MS, but it's a private build.

You can send it to my Microsoft email/teams if that's possible. I have a .iso unit test that is passing so its harder to nail down without a repro file. I can try to grab a couple bootable isos randomly and try to repro however.

why would there be ;

This is a bug that is fixed in main but the builds aren't being published currently. We transitioned to a new repo and are still working on getting the pipeline up here.

why would it reverse slash for files inside .tar?

This is something I'll need to address. But basically its because most non-windows things naturally use / paths.

@PrzemyslawKlys
Copy link
Author

Please give me your address - I'll send it over.

Another question - is the library simply to "show" files within archive or is it supposed to extract them as well on demand?

@gfs
Copy link
Contributor

gfs commented Aug 6, 2020

It extracts the files. The FileEntry objects returned contains a Content stream that contains the contents of the file.

@PrzemyslawKlys
Copy link
Author

Sent.

@gfs
Copy link
Contributor

gfs commented Aug 7, 2020

One of these mentioned files seems to be fixed in main.
The other two samples return no results when passed to DiscUtils (our ISO parsing dependency). That appears to be a bug in the DiscUtils library. Need to investigate finding a public .ISO that reproduces the 0 result issue.

@gfs gfs changed the title Access Control List (ACL) APIs are part of resource management on Windows and are not supported on this platform Some ISOs not parsed from DiscUtils Aug 11, 2020
@gfs
Copy link
Contributor

gfs commented Aug 11, 2020

Current issue is that some ISOs produce no enumerated files

@gfs
Copy link
Contributor

gfs commented Sep 22, 2022

When looking through issues on the DiskUtils repo I noticed this comment that some isos that don't parse correctly may be UDF formatted. DiskUtils also has a UDF reader so it might be worth retrying isos as UDF.

DiscUtils/DiscUtils#210

@gfs gfs added the external A bug in a library Recursive Extractor depends on label Oct 20, 2022
@SteAmeR
Copy link
Contributor

SteAmeR commented Jan 18, 2023

I apologize for raising the matter again, but the UDF issue still persists so I tried to fix it. I hope it helps.

@gfs
Copy link
Contributor

gfs commented Jan 23, 2023

Thanks for your help @SteAmeR with #120, which added an extractor for UDF isos without a joliet index.

@PrzemyslawKlys is it possible for you to retry with the file you were having issues with on the latest or to reach back out to provide the sample file again or perhaps explain how to generate a file of this type with test contents suitable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external A bug in a library Recursive Extractor depends on
Projects
None yet
Development

No branches or pull requests

3 participants