-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for userCol and itemCol as string types in SAR model #2283
base: master
Are you sure you want to change the base?
Conversation
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
2bbf3cc
to
d580344
Compare
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
core/src/main/scala/com/microsoft/azure/synapse/ml/recommendation/SAR.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/microsoft/azure/synapse/ml/recommendation/SARModel.scala
Outdated
Show resolved
Hide resolved
…ion/SARModel.scala
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2283 +/- ##
==========================================
- Coverage 84.53% 0.00% -84.54%
==========================================
Files 327 327
Lines 16788 16808 +20
Branches 1500 1499 -1
==========================================
- Hits 14191 0 -14191
- Misses 2597 16808 +14211 ☔ View full report in Codecov by Sentry. |
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
core/src/test/scala/com/microsoft/azure/synapse/ml/recommendation/SARSpec.scala
Outdated
Show resolved
Hide resolved
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
* **SAR.scala** - Update `calculateUserItemAffinities` method to handle integer types for `userId` and `itemId` - Update `calculateItemItemSimilarity` method to handle integer types for `userId` and `itemId` * **test_ranking.py** - Add test cases to verify the functionality of SAR model with integer types for `userId` and `itemId`
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…/recommendation/SARSpec.scala
…n SARSpec.scala * Add a test case for handling User Column with Strings * Add a test case for handling User Column with different datatypes * Verify the handling of User Column with Strings and other datatypes in SAR.scala * Ensure the new test cases are concise and focused on the new code * Place the new test cases in an appropriate location within the file
Fixes #2275
Add support for
userCol
anditemCol
as string types in the SAR model.Python Files:
core/src/main/python/synapse/ml/recommendation/SAR.py
to handle stringuserCol
anditemCol
.core/src/main/python/synapse/ml/recommendation/SARModel.py
to handle stringuserCol
anditemCol
in therecommendForUserSubset
function.Scala Files:
core/src/main/scala/com/microsoft/azure/synapse/ml/recommendation/SAR.scala
to handle stringuserCol
anditemCol
in thecalculateUserItemAffinities
andcalculateItemItemSimilarity
functions.core/src/main/scala/com/microsoft/azure/synapse/ml/recommendation/SARModel.scala
to handle stringuserCol
anditemCol
.Tests:
core/src/test/python/synapsemltest/recommendation/test_ranking.py
to include tests for stringuserCol
anditemCol
.core/src/test/scala/com/microsoft/azure/synapse/ml/recommendation/SARSpec.scala
to include tests for stringuserCol
anditemCol
.Documentation:
docs/Quick Examples/estimators/core/_Recommendation.md
to include examples with stringuserCol
anditemCol
.For more details, open the Copilot Workspace session.