-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding capability use Cognitive Service Language Service asynchronously for Summarization #2342
base: master
Are you sure you want to change the base?
Conversation
…ly. The transformer calls the async service and poll for result. The polling delay and max retry attempts is controlled by parameters. Request creation for each task is extracted into separate trait to make code more readable and manageable. There has been minimal changes in AnalyzeText class.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
//------------------------------------------------------------------------------------------------------ | ||
// Abstractive Summarization | ||
//------------------------------------------------------------------------------------------------------ | ||
object SummaryLength extends Enumeration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the spark bindings API handle enums? How does this look in the schema of the dataframe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a helper enum, the field in the class is of type string
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2342 +/- ##
===========================================
- Coverage 84.55% 71.62% -12.93%
===========================================
Files 328 331 +3
Lines 16848 17151 +303
Branches 1513 1515 +2
===========================================
- Hits 14246 12285 -1961
- Misses 2602 4866 +2264 ☔ View full report in Codecov by Sentry. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
What changes are proposed in this pull request?
Adding a new capability to use Cognitive Service Language Service asynchronously.
The transformer calls the async service and poll for result. The polling delay and max retry attempts is controlled by parameters. Request creation for each task is extracted into separate trait to make code more readable and manageable. There has been minimal changes in AnalyzeText class.
In this PR we adding support for following tasks
How is this patch tested?
Using unit tests, I have called each service and validated that transformer is working.
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
Note
Please note that this PR does not add capability to call
CustomMultiLableCalssification
andCustomSingleLableClassification
tasks. These tasks will be added in later PR