Autocomplete for string literal values fails when typing "/"

[gr2m]

TypeScript Version: [email protected]

Search Terms: is:issue is:open slash in:title , autocomplete in:title , is:open label:"Domain: Completion Lists"

Code

type Options = "one/two/three" | "two/three/one" | "three/one/two" 

function test(option: Options) {}

test("")

Expected behavior:

The suggested options for test() should update as I type the string. It should not be interrupted when I type "/" and it should not match all options when I type "one/" and press control space to trigger the auto complete

Actual behavior:

When I start typing "one" it will correctly list the three possible options

As soon as I type "one/" the autocomplete disappears

When I continue typing "one/two" all the options appear again, although only one of them should match

When I then select the "one/two/three" option, it adds the whole string

Playground Link: playground

Related Issues: follow up to octokit/endpoint.js#23 (comment)

[a-tarasyuk]

@weswigham I think it happens because the following condition is equal tofalse for the string enum values which include /

TypeScript/src/services/completions.ts

Lines 2124 to 2127 in 0c9db71

	case "/":
	return !!contextToken && (isStringLiteralLike(contextToken)
	? !!tryGetImportFromModuleSpecifier(contextToken)
	: contextToken.kind === SyntaxKind.SlashToken && isJsxClosingElement(contextToken.parent));

What do you think about ignoring / char for this case? Maybe there is helper which can be used to determine that it is string enum value.

[weswigham]

isValidTrigger should probably ignore unmatching quotes and all other triggers when within a string literal. Probably. I at least can't imagine why you'd want @ to trigger while you're in a string literal already.

[DanielRosenwasser]

Thanks @a-tarasyuk!

[gr2m]

😍 Thank you so much!

Will you add a comment when the fix was released? Or is it automatically published to the @next dist-tag? I couldn’t find any documentation on your process here, apologies if I missed it

[DanielRosenwasser]

It'll be in the next nightly, but 3.5 should be out next week.