Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Callout is slow #243

Open
richardtagger opened this issue Feb 6, 2018 · 2 comments
Open

Callout is slow #243

richardtagger opened this issue Feb 6, 2018 · 2 comments

Comments

@richardtagger
Copy link
Contributor

Looking at flame graphs when debugging typeahead performance reveals hundreds of milliseconds spent recalculating styles in Fabric's Stylesheet.js. The root cause appears to be originating from Callout. Current approach will be to ditch use of Callout for type ahead - we actually don't need the things it provides such as animation, and positioning logic and are better off using an absolutely positioned `DIV with a border radius + shadow. However, future features that are highly interactive and re-render on keypresses may encounter similar issues.

Chrome Perf Profile.zip

screen shot 2018-02-06 at 12 01 18 pm

@swese44
Copy link
Contributor

swese44 commented Feb 6, 2018

please report this in Fabric. we get things like positioning + beak for free and it would be ideal to get perf issues fixed in the Fabric repo rather than own this ourselves

@richardtagger
Copy link
Contributor Author

Well we don't use beak or positioning for the editor, but yes we'll use Callout for other things. I will report it to the team

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants