Python: ChatKit sample fixes #2174
Merged
+3,646
−3,546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
documentation
Copilot finished reviewing on behalf of
moonbox3
November 13, 2025 08:46
Member
Python Test Coverage Report •
Python Unit Test Overview
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes critical context retention issues in the ChatKit integration sample by ensuring the agent maintains conversation history throughout the chat session. Previously, only the most recent user message was being passed to the agent, causing disjointed conversations.
Key Changes
- Modified the
respondmethod to load full thread history before processing each message, ensuring conversation context is maintained - Added automatic thread title generation using LLM-based summarization
- Applied code formatting fixes including import reordering and whitespace cleanup
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| python/samples/demos/chatkit-integration/app.py | Core fix: loads full thread history for context retention; adds LLM-based thread title generation; reorganizes imports |
| python/packages/chatkit/README.md | Updates documentation example to show loading full thread history instead of just the current message |
| python/samples/demos/chatkit-integration/store.py | Formatting changes: reorders imports alphabetically, reformats multi-line statements |
| python/samples/demos/chatkit-integration/attachment_store.py | Formatting changes: reorders TYPE_CHECKING import, removes trailing whitespace |
| python/samples/demos/chatkit-integration/weather_widget.py | Formatting: removes extra blank line |
eavanvalkenburg
approved these changes
Nov 13, 2025
dmytrostruk
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While running the ChatKit sample, it was noticed that we do not hold on to the thread as the convo continues. The introduces some disjointed chats with the LLM as we don't carry the context. Additionally, the thread names were left as "New Thread." Introduce a quick method to make a cheap call to get the context for the thread.
Description
Fixes. Other fixes, outside of app, are formatting / lint / package reordering.
Contribution Checklist