Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this warning message needed: "You specified releaseNotes - so you need to provide fastlane session, app specific password only won't work" #289

Open
syewchuk opened this issue Oct 14, 2022 · 4 comments
Assignees
Labels
Area: AppStore awaiting deployment Related changes are waiting for deployment to be completed

Comments

@syewchuk
Copy link

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Bug/Feature

Enter Task Name: AppStoreRelease@1

list here (V# not needed):
https://github.com/microsoft/app-store-vsts-extension/tree/master/Tasks/AppStoreRelease
https://github.com/microsoft/app-store-vsts-extension/blob/master/Tasks/AppStoreRelease/app-store-release.ts

Environment

  • Server - Azure Pipelines or TFS on-premises?
    Azure Pipelines

  • Agent - Hosted or Private:

    • If using Hosted agent, provide agent queue name:
    • macos-latest

Issue Description

I am always getting this warning message even though I can upload release notes without issue:

"##[warning]You specified releaseNotes - so you need to provide fastlane session, app specific password only won't work"

  • I can update release notes fine
  • I am using a service connection with API key to authenticate and upload to the AppStore (not username/password)

I do not think I should get this warning message since the release notes are uploaded without issue.

The error message is coming from this line in app-store-release.ts:

292                if (usingReleaseNotes) {
293                    if (!credentials.fastlaneSession) {
294                        tl.warning(tl.loc('ReleaseNotesRequiresFastlaneSession'));
295                    }
296
297                    pilotCommand.arg(['--changelog', fs.readFileSync(releaseNotes).toString()]);
298                }

Perhaps this message is a vestige from before API key authentication was added?
Or maybe fastlane has changed?

appstore_release_task_logs.txt

@LiliaSabitova
Copy link
Contributor

Hi @syewchuk thank you for reporting the issue.
Yes, look like this warning is a vestige.
We'll get back to it as soon as we have enough capacity.

@LiliaSabitova LiliaSabitova self-assigned this Oct 18, 2022
@rmorrin
Copy link

rmorrin commented Oct 25, 2022

Is there any progress on this issue? We're seeing the same warning and also using API key for authentication. Release notes are updated without any problems.

@LiliaSabitova
Copy link
Contributor

Hi @rmorrin, I'm working on this issue now.

@LiliaSabitova LiliaSabitova added the awaiting deployment Related changes are waiting for deployment to be completed label Nov 14, 2022
@LiliaSabitova
Copy link
Contributor

Merged changes to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AppStore awaiting deployment Related changes are waiting for deployment to be completed
Projects
None yet
Development

No branches or pull requests

3 participants