From b66855cc5cb87b5a1c6e925ab84a532ec9c72e8b Mon Sep 17 00:00:00 2001
From: Coby Allred <cobya@github.com>
Date: Wed, 16 Oct 2024 08:29:22 -0700
Subject: [PATCH] Don't attempt to install .NET 8 without explicit variable
 (#528)

With v1.3.0 not being fully released yet, attempting download of Net8
bits may fail if not explicitly setting v1.3.0-alpha in
`installcredprovider.sh`. Update the variable check to avoid "default"
downloads of .NET 8.
---
 helpers/installcredprovider.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/helpers/installcredprovider.sh b/helpers/installcredprovider.sh
index 076fc1c..f72a39d 100755
--- a/helpers/installcredprovider.sh
+++ b/helpers/installcredprovider.sh
@@ -11,7 +11,7 @@
 REPO="Microsoft/artifacts-credprovider"
 NUGET_PLUGIN_DIR="$HOME/.nuget/plugins"
 
-# determine whether we install default or Net6
+# .NET 6 is the default installation, attempt to install unless set to false.
 if [ -z ${USE_NET6_ARTIFACTS_CREDENTIAL_PROVIDER} ] || [ ${USE_NET6_ARTIFACTS_CREDENTIAL_PROVIDER} != "false" ]; then
   FILE="Microsoft.Net6.NuGet.CredentialProvider.tar.gz"
 
@@ -22,7 +22,8 @@ if [ -z ${USE_NET6_ARTIFACTS_CREDENTIAL_PROVIDER} ] || [ ${USE_NET6_ARTIFACTS_CR
       exit 1
       ;;
   esac
-elif [ -z ${USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER} ] || [ ${USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER} != "false" ]; then
+# Don't attempt to install .NET 8 without a set variable.
+elif [ ! -z ${USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER} ] && [ ${USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER} != "false" ]; then
   FILE="Microsoft.Net8.NuGet.CredentialProvider.tar.gz"
 
   # throw if version starts < 1.3.0. (net8 not supported)
@@ -32,6 +33,7 @@ elif [ -z ${USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER} ] || [ ${USE_NET8_ARTIFACTS_
       exit 1
       ;;
   esac
+# If .NET 6 is disabled and .NET 8 isn't explicitly enabled, fall back to the legacy .NET Framework.
 else
   FILE="Microsoft.NuGet.CredentialProvider.tar.gz"
 fi