From b241e92d3e3fdc862032ec0d059010303331a0f7 Mon Sep 17 00:00:00 2001 From: Dmitrii Bobreshev <106314398+DmitriiBobreshev@users.noreply.github.com> Date: Mon, 24 Jul 2023 15:58:24 +0200 Subject: [PATCH] [azure-pipelines-tasks-webdeployment-common] - Fix ms deploy for node 16 (#199) - Fix the "Unrecognized argument" for the msdeploy on Node16. The fix also works fine for node 10 --- .../webdeployment-common/deployusingmsdeploy.ts | 3 ++- common-npm-packages/webdeployment-common/package-lock.json | 2 +- common-npm-packages/webdeployment-common/package.json | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/common-npm-packages/webdeployment-common/deployusingmsdeploy.ts b/common-npm-packages/webdeployment-common/deployusingmsdeploy.ts index 708bc26c..d964684c 100644 --- a/common-npm-packages/webdeployment-common/deployusingmsdeploy.ts +++ b/common-npm-packages/webdeployment-common/deployusingmsdeploy.ts @@ -174,7 +174,8 @@ async function executeMSDeploy(msDeployCmdArgs) { for(var i = 0 ; i < msDeployCmdArgs.length ; i++ ) { tl.debug("arg#" + i + ": " + msDeployCmdArgs[i]); } - await tl.exec("msdeploy", msDeployCmdArgs, {failOnStdErr: true, errStream: errObj, windowsVerbatimArguments: true}); + // for windowsVerbatimArguments: false see https://github.com/microsoft/azure-pipelines-tasks/issues/17634 + await tl.exec("msdeploy", msDeployCmdArgs, {failOnStdErr: true, errStream: errObj, windowsVerbatimArguments: false}); deferred.resolve("Azure App service successfully deployed"); } catch (error) { msDeployError = error; diff --git a/common-npm-packages/webdeployment-common/package-lock.json b/common-npm-packages/webdeployment-common/package-lock.json index 07b04d1b..32e2d3ab 100644 --- a/common-npm-packages/webdeployment-common/package-lock.json +++ b/common-npm-packages/webdeployment-common/package-lock.json @@ -1,6 +1,6 @@ { "name": "azure-pipelines-tasks-webdeployment-common", - "version": "4.224.0", + "version": "4.225.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/common-npm-packages/webdeployment-common/package.json b/common-npm-packages/webdeployment-common/package.json index bb4f949c..33ec4d96 100644 --- a/common-npm-packages/webdeployment-common/package.json +++ b/common-npm-packages/webdeployment-common/package.json @@ -1,6 +1,6 @@ { "name": "azure-pipelines-tasks-webdeployment-common", - "version": "4.224.0", + "version": "4.225.0", "description": "Common Lib for MSDeploy Utility", "repository": { "type": "git",