Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show path of default jdk as well in the notification #196

Open
yuyully opened this issue Nov 13, 2024 · 3 comments
Open

Show path of default jdk as well in the notification #196

yuyully opened this issue Nov 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@yuyully
Copy link

yuyully commented Nov 13, 2024

Gradle for java: v3.17.0

When default sdk is not compatible with current gradle version, there is a notification as below, the message should also show what default sdk version is detected.

Repro steps:

  1. Make sure there is JDK 8 in your local machine and JAVA_HOME is not JDK 8.
  2. Don't set gradle import java version in vscode settings
  3. Clone and open https://github.com/lenskit/lenskit.git

Image

@jdneo jdneo added the enhancement New feature or request label Nov 13, 2024
@jdneo
Copy link
Member

jdneo commented Nov 13, 2024

@Tanish-Ranjan

Do you remember that the default jdk is the jdk used to launch the gradle server, right?

@Tanish-Ranjan
Copy link
Contributor

@jdneo Yes if the default jdk is compatible, it will be used to launch the BuildServer otherwise we try to find a compatible jdk.

@jdneo
Copy link
Member

jdneo commented Nov 13, 2024

Ok

Convert the request to 'Show path of default jdk as well in the notification'

@jdneo jdneo changed the title Expect to show specific default sdk version in notification message Show path of default jdk as well in the notification Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants