Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot clone the public repo of an org without granting full org access #236

Open
sylveon opened this issue Sep 28, 2023 · 4 comments
Open
Assignees
Labels
Area-Machine-Config Related to machine configuration feature Area-Repo Related to repository operations Issue-Bug Something isn't working or needs investigation Needs-Discussion Requires a team discussion before proceeding Priority-2

Comments

@sylveon
Copy link

sylveon commented Sep 28, 2023

Dev Home version

0.503.261.0

Windows build number

10.0.22621.2361

Other software

No response

Steps to reproduce the bug

  1. On your account, have an org you own with a public repo on it. Make that membership public.
  2. Link Dev Home to GitHub, but don't grant access to that org.
  3. Try to clone the repo through Dev Home, via the "accounts" tab

Expected result

I expected to find that repo in the accounts tab, since it is public, and I am publicly member of that organization

Actual result

The repo is missing.

Included System Information

No response

@sylveon sylveon added the Issue-Bug Something isn't working or needs investigation label Sep 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Sep 28, 2023
@krschau krschau added the Area-Repo Related to repository operations label Nov 14, 2023
@vineeththomasalex
Copy link
Contributor

This was a GitHub access problem where having org repo access causes you to lose access to the org's public repos.

@dkbennett Did we have a way to fix this by using a public-only client for public repositories?

@krschau krschau added Area-Account-Sign-In Related to authenticating your GitHub account or anything related to sign-in and removed Area-Repo Related to repository operations labels Jan 10, 2024
@dkbennett
Copy link
Member

dkbennett commented Jan 10, 2024

Public client could be used for public repositories as a fallback (this logic exists already), however the rate limit on public client is extremely low. I doubt more than one widget for a repository using the public client can be used without hitting the rate limit.

The rate limit for an authenticated user is 5000 requests per hour. The rate limit for unauthenticated user is 60 per hour. Two orders of magnitude difference. It's very easy to eat up rate limit for the public (unauthenticated) client.

@sylveon
Copy link
Author

sylveon commented Jan 10, 2024

Not trying to use it for widgets, just want to clone it.

@vineeththomasalex
Copy link
Contributor

@dhoehna Do we have the same logic for Repo cloning?

@vineeththomasalex vineeththomasalex added Needs-Discussion Requires a team discussion before proceeding Priority-2 and removed Needs-Triage New issue that the core contributors need to triage labels Jan 22, 2024
@vineeththomasalex vineeththomasalex added Area-Repo Related to repository operations and removed Area-Account-Sign-In Related to authenticating your GitHub account or anything related to sign-in labels Aug 29, 2024
@kanismohammed kanismohammed added the Area-Machine-Config Related to machine configuration feature label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Machine-Config Related to machine configuration feature Area-Repo Related to repository operations Issue-Bug Something isn't working or needs investigation Needs-Discussion Requires a team discussion before proceeding Priority-2
Projects
None yet
Development

No branches or pull requests

6 participants