-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add ASPNET Accessibility Compat Document #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@HongGit, |
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HongGit, some corrections, a couple of questions, and a comment.
|
|
||
|
|
||
| ### Change Description | ||
| ASP.NET is improving how ASP.NET Web Controls work with accessibility technology in Visual Studio to better support ASP.NET customers. These includ the following changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
includ --> include
|
|
||
| ### Change Description | ||
| ASP.NET is improving how ASP.NET Web Controls work with accessibility technology in Visual Studio to better support ASP.NET customers. These includ the following changes: | ||
| - Changes to implement missing UI accessbility patters in controls, like the Add Field dialog in Details View wizard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patters --> patterns
in Details View --> in the Details View
| ### Change Description | ||
| ASP.NET is improving how ASP.NET Web Controls work with accessibility technology in Visual Studio to better support ASP.NET customers. These includ the following changes: | ||
| - Changes to implement missing UI accessbility patters in controls, like the Add Field dialog in Details View wizard. | ||
| - Changes to improve display in High Contrast mode, like the Data Pager Fields Editor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display --> the display
| ASP.NET is improving how ASP.NET Web Controls work with accessibility technology in Visual Studio to better support ASP.NET customers. These includ the following changes: | ||
| - Changes to implement missing UI accessbility patters in controls, like the Add Field dialog in Details View wizard. | ||
| - Changes to improve display in High Contrast mode, like the Data Pager Fields Editor. | ||
| - Improve the keyboard navigation experiences for controls, like Configure Object Context Window or Configure Data Source Window, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve --> Changes to improve
like Configure --> like the Configure
or Configure --> or the Configure
Window, etc. --> Window.
| ### Recommended Action | ||
| +__How to opt in or out of these changes__ | ||
|
|
||
| +In order for the Visual Studio IDE designer to benefit from these changes, it must run on the .NET Framework 4.7.1 or later. The web application can benefit from these changes in either of the following ways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual Studio IDE designer, or Visual Studio Designer?
| +__How to opt in or out of these changes__ | ||
|
|
||
| +In order for the Visual Studio IDE designer to benefit from these changes, it must run on the .NET Framework 4.7.1 or later. The web application can benefit from these changes in either of the following ways: | ||
| - Install Visual Studio 2017 15.3 or later, which ships with the following AppContext Switch by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ships with... --> supports the new accessibility features by default. (Is this correct?)
Question: does the ASP.NET app need to target the .NET Framework 4.7.1.
|
|
||
| +In order for the Visual Studio IDE designer to benefit from these changes, it must run on the .NET Framework 4.7.1 or later. The web application can benefit from these changes in either of the following ways: | ||
| - Install Visual Studio 2017 15.3 or later, which ships with the following AppContext Switch by default. | ||
| - Opt out of the legacy accessibility behaviors by adding the __Switch.UseLegacyAccessibility__ AppContext Switch to the ```<runtime>``` section in the devenv.exe.config file and setting it to false, as the following example shows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false --> false
| - Changes to implement missing UI accessbility patters in controls, like the Add Field dialog in Details View wizard. | ||
| - Changes to improve display in High Contrast mode, like the Data Pager Fields Editor. | ||
| - Improve the keyboard navigation experiences for controls, like Configure Object Context Window or Configure Data Source Window, etc. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this needs the following added:
- Quirked
- Build-time break
| </runtime> | ||
| </configuration> | ||
| ``` | ||
| Applications that target the .NET Framework 4.7.1 or later and want to preserve the legacy accessibility behavior can opt in to the use of legacy accessibility features by explicitly setting this AppContext switch to true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true --> 'true'
|
It also occurs to me, @HongGit, that the detail on what accessibility changes were implemented is somewhat sparse. Can you add more detail? |
|
@rpetrusha I incorporated your feedback, please review the changes! Could you please clarify a bit more on "more details"? |
|
|
||
| ### Change Description | ||
| ASP.NET is improving how ASP.NET Web Controls work with accessibility technology in Visual Studio to better support ASP.NET customers. These include the following changes: | ||
| - Changes to implement missing UI accessbility patterns in controls, like the Add Field dialog in the Details View wizard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessbility -> accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed in the next commit.
|
|
||
| Quirked | ||
|
|
||
| Build-time breake## ASP.NET Accessibility Improvement in .NET 4.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Quirked" and "Build-time breake" seem to be out of place here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed in the next commit.
| ### Recommended Action | ||
| +__How to opt in or out of these changes__ | ||
|
|
||
| +In order for the Visual Studio Designer to benefit from these changes, it must run on the .NET Framework 4.7.1 or later. The web application can benefit from these changes in either of the following ways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two lines above shouldn't start with a +.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed in the next commit.
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @HongGit. I'll merge it now.
* Add headers to dotnet-consumer-projects.md * Tanya's content and Ron's feedback * Next round of changes Second round of feedback plus a couple of bugs. * Fixed version reverted * More bugs * PropertyGrid changes Additional changes for the Property Grid plus some additional tweaks. * Added UIAutomation blurb Added blurb for Nikola's bug and overall UIAutomation improvements. * Incorporating feedback * Bullets Remove extra bullet * feedback * Updates for .net framework 4.7.1 early access build 2539 (#479) * Tanya's Review Tanya's Review * Add ASPNET Accessibility Compat Document (#484) * Add ASPNET Accessibility Compat Document * Update ASPNET Accessibility Improvement.md * Update ASPNET Accessibility Improvement.md @rpetrusha incorporated feedback * ASPNET Accessibility Improvement.md * minor fixups * Update xrefs Found some missing punctuation and updated the xref:s to displayProperty=nameWithType * Add the open source project named surging (#490) * Add the open source project named surging * Correct the problem changes to Libraries * Update dotnet-developer-projects.md * WCF 4.7.1 fixes with appcontext switch document * Fix typo in compatibility README.md (#497) * Create SerialPort-background-thread-exceptions.md (#485) * Create SerialPort-background-thread-exceptions.md * Update SerialPort-background-thread-exceptions.md * Update SerialPort-background-thread-exceptions.md * Update SerialPort-background-thread-exceptions.md * Update SerialPort-background-thread-exceptions.md * Reviewed WCF app compat topics (#496) * Add breaking change docs (#487) * Add breaking change docs * Update Change-SignedXML-and-SignedCMS-default-algorithms-to-SHA256.md * Update Change-SignedXML-and-SignedCMS-default-algorithms-to-SHA256.md * Update RSACng-and-DSACng-not-usable-in-Partial-Trust-scenarios.md * Update SignedXml.GetPublicKey-returns-RSACng-on-net462.md * Update docs for SignedXML fixes * Remove unclosed comment in doc * Fixup some SignedXml docs * Fixup some SignedXml docs * Added AspectCore to .NET Open Source Developer Projects (#495) AspectCore is an Aspect-Oriented Programming based cross platform framework for .NET Core and .NET Framework. Core support for aspect-interceptor,dependency injection integration , web applications , and more. * .NET Native 2.0 initial draft * Fixes based on feedback and rename the file. (#501) * Add ASPNET Accessibility Compat Document * Update ASPNET Accessibility Improvement.md * Update ASPNET Accessibility Improvement.md @rpetrusha incorporated feedback * ASPNET Accessibility Improvement.md * minor fixups * Add more details and rename the file * Update README.md formatting * Update README.md formatting * Update README.md formatting * Correct name of Visual Studio 2017 Version 15.4 * Update funceval.md * FuncEval release notes Add VS screen shots for funceval notes * fix typo * Update incremental-compilation.md * Update links of Win Application Framework (WAF) and Waf DotNetPad (#503) * Update wording * Update link of Waf Music Manager (#502) * Update link of Waf Music Manager * makes fun --> makes it fun * Fixing version number * Fix broken docId * Fixing DocIds * Fixed 3 broken links * Added 2 4.5 changes, fixed formatting (#508) * Corrections to WinForms accessibility topic (#511) * Removed leftover plural (#515) * Changes to parallel changes to dotnet/docs repo (#512) * Added 4.7 JIT issue (#516) * Added JIT issue * Added JIT issue * Added readme.md * Added link to GitHub issue
Add ASP.NET .NET 4.7.1 Accessibility Compat Documentation.