-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Avatar backgroundColor algorithm should match iOS #392
Comments
10 tasks
7 tasks
@kubalani we can close this now? |
The algorithms still don't match, so the same Name/Email won't give the same color. That was a followup task |
This is closed now? @kubalani |
7 tasks
The scope of previous PR was only restricted to theme changes, I have updated the initials view algorithm to address this issue specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Platform
Describe the feature that you would like added
There is a hashing algorithm in Avatar to choose a background color given the primaryText/secondaryText of the avatar.
On iOS this was purposefully chosen to match the FluentUI Android implementation. Let's use the same implementation for macOS, which currently uses a slightly different hashing algorithm resulting in different colors.
What component or utility would this be added to
macOS Avatar
Have you discussed this feature with our team, and if so, who
Yes. @markavitale and @harrieshin
Additional context/screenshots
The text was updated successfully, but these errors were encountered: