Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that useFocus hooks are properly merged with user provided refs #26245

Closed
1 task
micahgodbolt opened this issue Jan 6, 2023 · 2 comments
Closed
1 task
Assignees
Labels
Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Type: Bug 🐛

Comments

@micahgodbolt
Copy link
Member

micahgodbolt commented Jan 6, 2023

#24154 added a polyfill for focus visible and focus within, but on several components the ref returned by the hooks was added to the defaultProps, therefor any ref passed in by the user would override the ref and break focus rectangles.

This is being fixed in Slider by #26243

but we'll need to go through the rest of the controls where these hooks were added and make sure they merge with user props properly.

#26245 (comment)

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 6, 2023
@micahgodbolt micahgodbolt reopened this Jun 6, 2023

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Type: Bug 🐛
Projects
None yet
Development

No branches or pull requests

2 participants